fix test assertions

knative · Feb 24, 2021 · 6af1bba · 6af1bba
1 parent eb66ca2
commit 6af1bba
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc
@@ -39,8 +39,8 @@
 | https://github.com/knative/client/pull/1194[#1194]
 
 | ✨
-| Use server-side generated revision names by default now. For BYO revision names use `--revision name` for service commands
-| https://github.com/knative/client/issues/1144[#1144]
+| Use server-side generated revision names by default now. For BYO revision names use `--revision-name` for service commands
+| https://github.com/knative/client/issues/1240[#1240]
 |===
 
 ## v0.20.0 (2021-01-14)

diff --git a/test/e2e/revision_test.go b/test/e2e/revision_test.go
@@ -51,7 +51,7 @@ func TestRevision(t *testing.T) {
 	test.RevisionListWithService(r, "hello")
 
 	t.Log("update hello service and increase revision count to 3")
-	test.ServiceUpdate(r, "hello", "--env", "TARGET=kn", "--port", "8888")
+	test.ServiceUpdate(r, "hello", "--env", "TARGET=kn", "--port", "9000")
 
 	t.Log("delete three revisions with one revision a nonexistent")
 	existRevision1 := test.FindRevisionByGeneration(r, "hello", 1)

diff --git a/test/e2e/service_test.go b/test/e2e/service_test.go
@@ -96,7 +96,7 @@ func serviceCreatePrivateUpdatePublic(r *test.KnRunResultCollector, serviceName
 	out = r.KnTest().Kn().Run("service", "update", serviceName,
 		"--image", pkgtest.ImagePath("helloworld"), "--no-cluster-local")
 	r.AssertNoError(out)
-	assert.Check(r.T(), util.ContainsAllIgnoreCase(out.Stdout, "service", serviceName, "unchanged", "namespace", r.KnTest().Kn().Namespace(), "ready"))
+	assert.Check(r.T(), util.ContainsAllIgnoreCase(out.Stdout, "service", serviceName, "no new revision", "namespace", r.KnTest().Kn().Namespace()))
 
 	out = r.KnTest().Kn().Run("service", "describe", serviceName, "--verbose")
 	r.AssertNoError(out)