Error when trying to BYO revision name to an old-format service

knative · Jul 20, 2019 · 0eb0c77 · 0eb0c77
1 parent 941f643
commit 0eb0c77
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/pkg/kn/commands/service/configuration_edit_flags.go b/pkg/kn/commands/service/configuration_edit_flags.go
@@ -138,7 +138,9 @@ func (p *ConfigurationEditFlags) Apply(
 	}
 	if anyMutation {
 		err = servinglib.UpdateName(template, name)
-		if err != nil {
+		if err == servinglib.ApiTooOldError && !cmd.Flags().Changed("revision-name") {
+			// pass
+		} else if err != nil {
 			return err
 		}
 	}

diff --git a/pkg/serving/config_changes.go b/pkg/serving/config_changes.go
@@ -15,6 +15,7 @@
 package serving
 
 import (
+	"errors"
 	"fmt"
 	"strconv"
 
@@ -62,8 +63,13 @@ func UpdateAnnotation(template *servingv1alpha1.RevisionTemplateSpec, annotation
 	annoMap[annotation] = value
 }
 
+var ApiTooOldError = errors.New("The service is using too old of an API format for the operation")
+
 // UpdateName updates the revision name.
 func UpdateName(template *servingv1alpha1.RevisionTemplateSpec, name string) error {
+	if template.Spec.DeprecatedContainer != nil {
+		return ApiTooOldError
+	}
 	template.Name = name
 	return nil
 }