-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
plugins/source-kafka/README.md
Outdated
@@ -0,0 +1,89 @@ | |||
## kn-source_kafka | |||
|
|||
`kn-source_kafka` is a plugin of Knative Client, which allows you to management of Kafka event source interactively from the command line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it is called kn-source_kafka
and now kn-source-kafka
? I would expect a command like kn source kafka
much like kn source apiserver
or any other source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maximilien mentioned that currently kn command, e.g. kn source
, was not allowed to be extended. That is, I'm not allowed to add a subcommand kafka
to kn source
. But it can be changed. We could talk about that in the meeting tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if this doesn't work for kn
we should fix it. Its a key feature to make built-in source, plugin source and dynamical, generic source the same for the user experience (as it really doesn't matter for the user how a source is implemented, the usage across all sources should be uniform).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, we need to have a way to make exception for kn source
group. Will open an issue and submit a PR for this tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See issue client
issue #814
plugins/source-kafka/vendor/github.com/hashicorp/hcl/hcl/scanner/scanner.go
Show resolved
Hide resolved
plugins/source-kafka/vendor/github.com/hashicorp/hcl/json/scanner/scanner.go
Show resolved
Hide resolved
plugins/source-kafka/vendor/github.com/spf13/jwalterweatherman/README.md
Show resolved
Hide resolved
plugins/source-kafka/vendor/github.com/spf13/jwalterweatherman/README.md
Show resolved
Hide resolved
plugins/source-kafka/vendor/github.com/hashicorp/hcl/json/scanner/scanner.go
Show resolved
Hide resolved
plugins/source-kafka/vendor/github.com/hashicorp/hcl/hcl/scanner/scanner.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/test pull-knative-client-contrib-integration-tests
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: daisy-ycguo, maximilien The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
888880d
to
ff7de36
Compare
/test pull-knative-client-contrib-integration-tests |
I will close this PR, refactor it and separate into two PRs for easy review. |
The source-kafka plugin includes: