Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Fix issue that CHANGED_FILES is empty #17

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Fix issue that CHANGED_FILES is empty #17

merged 1 commit into from
Apr 16, 2020

Conversation

daisy-ycguo
Copy link
Member

@daisy-ycguo daisy-ycguo commented Apr 16, 2020 •
edited
Loading

Fixes issue #16
Add a sample e2e test in plugin hello

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Apr 16, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 16, 2020
@daisy-ycguo daisy-ycguo force-pushed the e2e1 branch 2 times, most recently from 0e9835a to a0b3d1e Compare April 16, 2020 09:04
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2020
@daisy-ycguo daisy-ycguo force-pushed the e2e1 branch 4 times, most recently from b755026 to 2ad36a7 Compare April 16, 2020 10:02
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2020
mattmoor
mattmoor reviewed Apr 16, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)

plugins/hello/test/e2e/basic_flow_test.go Outdated Show resolved Hide resolved
plugins/hello/test/e2e/basic_flow_test.go Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2020
maximilien
maximilien approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daisy-ycguo, maximilien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2020
@knative-prow-robot knative-prow-robot merged commit c72397b into knative:master Apr 16, 2020
zhangtbj pushed a commit to zhangtbj/client-contrib that referenced this pull request Apr 28, 2020
@zhangtbj
fix issue that CHANGED_FILES is empty (knative#17)
14aa197
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattmoor mattmoor mattmoor left review comments

@maximilien maximilien maximilien approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@maximilien maximilien

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daisy-ycguo @knative-prow-robot @maximilien @mattmoor @googlebot