Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

fix build uncorrect status #600

Closed
wants to merge 1 commit into from
Closed

fix build uncorrect status #600

wants to merge 1 commit into from

Conversation

zouyee
Copy link

@zouyee zouyee commented Apr 25, 2019

Fixes #599

Proposed Changes

  • check build status before stop it.

Release Note


@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zouyee
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: shashwathi

If they are not already assigned, you can assign the PR to them by writing /assign @shashwathi in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zouyee: 0 warnings.

In response to this:

Fixes ##599

Proposed Changes

  • check build status before stop it.

Release Note


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-metrics-robot
Copy link

The following is the coverage report on pkg/.
Say /test pull-knative-build-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/build/timeout_handler.go 67.3% 67.9% 0.6

@imjasonh
Copy link
Member

imjasonh commented Jun 6, 2019

Hi @zouyee -- sorry it's taken so long to get to this PR 😅

If this bug is still outstanding and reproducible, please add a test case that faiils without your code change to prevent accidentally regressing in some future refactor. A unit test change would also be nice.

@imjasonh
Copy link
Member

Closing this as stale, please reopen if you think this is still something we should do.

@imjasonh imjasonh closed this Jun 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build reported as a timeout when it actually succeeded
4 participants