Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

correct rbac api version #501

Merged
merged 1 commit into from
Dec 12, 2018
Merged

correct rbac api version #501

merged 1 commit into from
Dec 12, 2018

Conversation

zouyee
Copy link

@zouyee zouyee commented Dec 11, 2018

Proposed Changes

bump rbac version

Release Note

NONE

@knative-prow-robot
Copy link

Hi @zouyee. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@knative-prow-robot
Copy link

@zouyee: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-knative-build-go-coverage 02e8d49 link /test pull-knative-build-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zouyee
Copy link
Author

zouyee commented Dec 12, 2018

/test pull-knative-build-go-coverage

@knative-prow-robot
Copy link

@zouyee: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-knative-build-go-coverage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shashwathi
Copy link
Contributor

shashwathi commented Dec 12, 2018

@zouyee : go-coverage test is currently broken. Anyway it is not required for the PR to merge.

Copy link
Contributor

@shashwathi shashwathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for doing the PR. Great work @zouyee

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shashwathi, vdemeester, zouyee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 139288d into knative:master Dec 12, 2018
vdemeester pushed a commit to vdemeester/knative-build that referenced this pull request Apr 3, 2019
vdemeester pushed a commit to vdemeester/knative-build that referenced this pull request Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants