Publish nightly knative/build releases to knative-nightly #479
Conversation
Part of knative/serving#2555. Bonus: updates `test-infra` to include the latest fixes and features, while also updating the Gopkg files so the cleanup workaround in `update-deps.sh` is not necessary anymore.
adrcunha
force-pushed
the
nightly-gcs
branch
from
8b8ac54 to
b376178
Compare
| @@ -1,3 +1,3 @@ | |||
| baseImageOverrides: | |||
| github.com/knative/build/cmd/creds-init: gcr.io/knative-releases/github.com/knative/build/build-base:latest | |||
| github.com/knative/build/cmd/git-init: gcr.io/knative-releases/github.com/knative/build/build-base:latest | |||
| github.com/knative/build/cmd/creds-init: gcr.io/knative-nightly/github.com/knative/build/build-base:latest | |||
There was a problem hiding this comment.
Won't this make real releases base these images on the nightly base images? Is that a problem?
There was a problem hiding this comment.
Yes, it would, but that's how it is now. Nightlies are supposed to be stable because we run tests before publishing. We can base these images on the latest versioned release if thats better.
There was a problem hiding this comment.
oh that's not what I understood 🤔 😓 Shouldn't/couldn't ko be able to rewrite those knative-nightly when releasing ?
There was a problem hiding this comment.
It does rewrite then when building a new nightly release.
There was a problem hiding this comment.
We could have a separate .ko.yaml.release which we use when doing a real release, with KO_CONFIG_PATH=.ko.yaml.release ko resolve ...
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, ImJasonH, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Publish nightly knative/build releases to knative-nightly Part of knative/serving#2555. Bonus: updates `test-infra` to include the latest fixes and features, while also updating the Gopkg files so the cleanup workaround in `update-deps.sh` is not necessary anymore. * Use .ko.yaml.release for image overrides for versioned releases
* Publish nightly knative/build releases to knative-nightly Part of knative/serving#2555. Bonus: updates `test-infra` to include the latest fixes and features, while also updating the Gopkg files so the cleanup workaround in `update-deps.sh` is not necessary anymore. * Use .ko.yaml.release for image overrides for versioned releases
Part of knative/serving#2555.
Bonus: updates
test-infrato include the latest fixes and features, while also updating the Gopkg files so the cleanup workaround inupdate-deps.shis not necessary anymore.