Skip to content
This repository has been archived by the owner on Sep 5, 2019. It is now read-only.

Commit

Permalink
Fix typos (#593)
Browse files Browse the repository at this point in the history
* Fix typos

* Appease mdlint
  • Loading branch information
TommyLike authored and knative-prow-robot committed Apr 8, 2019
1 parent 4b817d9 commit 7e63198
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions pkg/credentials/gitcreds/ssh.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ func (dc *sshGitConfig) String() string {
func (dc *sshGitConfig) Set(value string) error {
parts := strings.Split(value, "=")
if len(parts) != 2 {
return fmt.Errorf("Expect entries of the form secret=url, got: %v", value)
return fmt.Errorf("expect entries of the form secret=url, got: %v", value)
}
secret := parts[0]
url := parts[1]

if _, ok := dc.entries[url]; ok {
return fmt.Errorf("Multiple entries for url: %v", url)
return fmt.Errorf("multiple entries for url: %v", url)
}

e, err := newSshEntry(url, secret)
Expand Down
6 changes: 3 additions & 3 deletions pkg/logs/logs.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func Tail(ctx context.Context, out io.Writer, buildName, namespace string) error

podName, err := podName(cfg, out, buildName, namespace)
if err != nil {
return fmt.Errorf("Error getting build pod: %v", err)
return fmt.Errorf("error getting build pod: %v", err)
}

client, err := corev1.NewForConfig(cfg)
Expand Down Expand Up @@ -213,13 +213,13 @@ func streamLogs(ctx context.Context, out io.Writer, containerName string, rc io.
func podName(cfg *rest.Config, out io.Writer, buildName, namespace string) (string, error) {
client, err := buildv1alpha1.NewForConfig(cfg)
if err != nil {
return "", fmt.Errorf("Error getting build client: %v", err)
return "", fmt.Errorf("error getting build client: %v", err)
}

for ; ; time.Sleep(time.Second) {
b, err := client.Builds(namespace).Get(buildName, metav1.GetOptions{IncludeUninitialized: true})
if err != nil {
return "", fmt.Errorf("Error getting build: %v", err)
return "", fmt.Errorf("error getting build: %v", err)
}

cluster := b.Status.Cluster
Expand Down
4 changes: 2 additions & 2 deletions pkg/reconciler/build/resources/pod.go
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ func MakePod(build *v1alpha1.Build, kubeclient kubernetes.Interface) (*corev1.Po
if build.Status.Cluster != nil && build.Status.Cluster.PodName != "" {
podName = build.Status.Cluster.PodName
} else {
return nil, fmt.Errorf("Can't create pod for build %q: pod name not set", build.Name)
return nil, fmt.Errorf("can't create pod for build %q: pod name not set", build.Name)
}

return &corev1.Pod{
Expand Down Expand Up @@ -420,7 +420,7 @@ func BuildStatusFromPod(p *corev1.Pod, buildSpec v1alpha1.BuildSpec) v1alpha1.Bu
// is the source-fetching container.
skip++
}
// Also skip multiple sourcees specified by the build.
// Also skip multiple sources specified by the build.
skip += len(buildSpec.Sources)
if skip <= len(p.Status.InitContainerStatuses) {
for _, s := range p.Status.InitContainerStatuses[skip:] {
Expand Down
2 changes: 1 addition & 1 deletion roadmap-2018.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ advances we've made with FTL-like layer caching techniques,
[remote image rebasing](https://github.com/google/image-rebase), source
detection, and in general be best-in-class in terms of fast incremental builds.

[GCB](cloud.google.com/container-builder/docs) already maintains a set of
[GCB](https://cloud.google.com/cloud-build/docs/) already maintains a set of
[officially-supported builders](https://github.com/GoogleCloudPlatform/cloud-builders),
and some
[contributed by community members](https://github.com/GoogleCloudPlatform/cloud-builders-community).
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# End to end tests

- [Running e2e tests](../README.md#running-e2e-tests)
- [Running e2e tests](../README.md#Running-end-to-end-tests)

## Adding end to end tests

Expand All @@ -17,4 +17,4 @@ The e2e tests **MUST**:

1. Provide frequent output describing what actions they are undertaking,
especially before performing long running operations.
2. Follow Golang best practices.
1. Follow Golang best practices.

0 comments on commit 7e63198

Please sign in to comment.