Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make kind local registry optional #428

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Make kind local registry optional #428

merged 3 commits into from
Jul 13, 2023

Conversation

psschwei
Copy link
Contributor

Changes

Fixes #393

Installing a local registry causes problems for podman users. This PR makes the local registry opt-in by passing a --registry flag.

Also bumps the Kubernetes version to v1.26.6.

Release Note

For Kind, a local registry will no longer be created by default. Users will need to pass the `--registry` flag if they wish to create a local registry.

@psschwei
make kind registry optional
9463013 
Signed-off-by: Paul S. Schweigert <[email protected]>
@knative-prow
Copy link

knative-prow bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dsimansk and rhuss July 12, 2023 13:43
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2023
dsimansk
dsimansk reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a temporary warning into the installation steps output about the change of default behavior? Wdyt?

Othewise looks good to me.

dsimansk
dsimansk reviewed Jul 12, 2023
View reviewed changes
internal/command/flags.go Outdated Show resolved Hide resolved
psschwei and others added 2 commits July 12, 2023 10:30
@dsimansk
Copy link
Contributor

Thanks!

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@psschwei
Copy link
Contributor Author

/easycla

@knative-prow knative-prow bot merged commit 76bfae1 into knative-extensions:main Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsimansk dsimansk dsimansk left review comments

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@dsimansk dsimansk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kn quickstart kind error exit status 1
2 participants
@psschwei @dsimansk