Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify symbolic link for LICENSE in kodata #247

Merged
merged 1 commit into from
Mar 8, 2020
Merged

Modify symbolic link for LICENSE in kodata #247

merged 1 commit into from
Mar 8, 2020

Conversation

MIBc
Copy link
Contributor

@MIBc MIBc commented Mar 8, 2020

Fixes #246

  • Modify symbolic link for LICENSE in kodata.

@MIBc
Modify symbolic link for LICENSE in kodata
f598abb 
* Modify symbolic link for LICENSE in kodata.
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 8, 2020
@knative-prow-robot
Copy link
Contributor

Welcome @MIBc! It looks like this is your first PR to knative/sample-controller 🎉

@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 8, 2020
@knative-prow-robot
Copy link
Contributor

Hi @MIBc. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MIBc
Copy link
Contributor Author

MIBc commented Mar 8, 2020

/assign @mattmoor

mattmoor
mattmoor reviewed Mar 8, 2020
View reviewed changes
Copy link
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops
/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, MIBc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2020
@knative-prow-robot knative-prow-robot merged commit 5c881c7 into knative-extensions:master Mar 8, 2020
@MIBc MIBc deleted the license branch March 9, 2020 03:04
@MIBc MIBc mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@mattmoor mattmoor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not build controller and webhook
3 participants
@MIBc @knative-prow-robot @mattmoor