Optimize cache warmup on startup #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 65.99% 65.06% -0.93%
==========================================
Files 17 17
Lines 641 624 -17
==========================================
- Hits 423 406 -17
Misses 191 191
Partials 27 27
Continue to review full report at Codecov.
|
markusthoemmes
force-pushed
the
optimize-cache-warmup
branch
2 times, most recently
from
1b96b1e
to
abacbe6
Compare
knative-prow-robot
added
the
needs-rebase
markusthoemmes
force-pushed
the
optimize-cache-warmup
branch
from
abacbe6
to
54d81c5
Compare
knative-prow-robot
removed
the
needs-rebase
|
It'd be good to rebase this PR to pick #282 and run the e2e tests. |
markusthoemmes
force-pushed
the
optimize-cache-warmup
branch
from
54d81c5
to
3fa42a0
Compare
|
Done! |
markusthoemmes
force-pushed
the
optimize-cache-warmup
branch
2 times, most recently
from
02b8d23
to
956d964
Compare
markusthoemmes
force-pushed
the
optimize-cache-warmup
branch
3 times, most recently
from
0c92bf2
to
6a89c78
Compare
knative-prow-robot
added
the
needs-rebase
markusthoemmes
force-pushed
the
optimize-cache-warmup
branch
from
6a89c78
to
6e2d69d
Compare
knative-prow-robot
removed
the
needs-rebase
markusthoemmes
force-pushed
the
optimize-cache-warmup
branch
from
6e2d69d
to
a4f328d
Compare
markusthoemmes
force-pushed
the
optimize-cache-warmup
branch
from
a4f328d
to
9ac1af7
Compare
|
The following is the coverage report on the affected files.
|
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes cache warmup at startup simpler (and most likely faster too):
Instead of relying on the global resync to do its thing (which can be very slow, especially because of our two-lane queues), this runs all the ingresses through the reconciler without queueing them and before launching the config server. Having this seeded config is necessary to start it anyway, so we might as well block startup on it completely.