[release-1.11] Fix an issue where getReadyIngresses was not loading ready ingresses at startup #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indeed, we can't use label selector as kourier class is not a label, but an annotation. As a result, kourier does not sync ingresses at startup
knative-prow
bot
added
the
size/S
Codecov Report
@@ Coverage Diff @@
## release-1.11 #1081 +/- ##
=============================================
Coverage 80.95% 80.95%
=============================================
Files 18 18
Lines 1355 1355
=============================================
Hits 1097 1097
Misses 205 205
Partials 53 53 |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, nak3, xtreme-vikram-yadav The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
knative-prow
bot
merged commit a48c118
into
knative-extensions:release-1.11
17 checks passed
openshift-merge-robot
pushed a commit
to openshift-knative/net-kourier
that referenced
this pull request
Aug 2, 2023
* [release-1.11] Fix an issue where getReadyIngresses was not loading ready ingresses at startup (knative-extensions#1081) * Update getReadyIngresses to load ingresses at startup Indeed, we can't use label selector as kourier class is not a label, but an annotation. As a result, kourier does not sync ingresses at startup * Explain KUBE_API_BURST and KUBE_API_QPS --------- Co-authored-by: norbjd <[email protected]> * Sync upstream release --------- Co-authored-by: Knative Prow Robot <[email protected]> Co-authored-by: norbjd <[email protected]> Co-authored-by: John Doe <johndoe@localhost> Co-authored-by: nak3 <[email protected]>
openshift-merge-robot
pushed a commit
to openshift-knative/net-kourier
that referenced
this pull request
Sep 14, 2023
* [release-1.11] Fix an issue where getReadyIngresses was not loading ready ingresses at startup (knative-extensions#1081) * Update getReadyIngresses to load ingresses at startup Indeed, we can't use label selector as kourier class is not a label, but an annotation. As a result, kourier does not sync ingresses at startup * Explain KUBE_API_BURST and KUBE_API_QPS --------- Co-authored-by: norbjd <[email protected]> * Do not use informer for startupTranslator (knative-extensions#1109) Co-authored-by: Kenjiro Nakayama <[email protected]> --------- Co-authored-by: Knative Prow Robot <[email protected]> Co-authored-by: norbjd <[email protected]> Co-authored-by: Kenjiro Nakayama <[email protected]> Co-authored-by: John Doe <johndoe@localhost>
openshift-ci bot
pushed a commit
to openshift-knative/net-kourier
that referenced
this pull request
Oct 13, 2023
* [release-1.11] Fix an issue where getReadyIngresses was not loading ready ingresses at startup (knative-extensions#1081) * Update getReadyIngresses to load ingresses at startup Indeed, we can't use label selector as kourier class is not a label, but an annotation. As a result, kourier does not sync ingresses at startup * Explain KUBE_API_BURST and KUBE_API_QPS --------- Co-authored-by: norbjd <[email protected]> * Do not use informer for startupTranslator (knative-extensions#1109) Co-authored-by: Kenjiro Nakayama <[email protected]> * Leave a comment which will trigger a new dot release (knative-extensions#1134) Co-authored-by: Reto Lehmann <[email protected]> * [release-1.11] bump x/net to v0.17 (knative-extensions#1137) --------- Co-authored-by: Knative Prow Robot <[email protected]> Co-authored-by: norbjd <[email protected]> Co-authored-by: Kenjiro Nakayama <[email protected]> Co-authored-by: Reto Lehmann <[email protected]> Co-authored-by: John Doe <johndoe@localhost>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #1079