-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Upgrade to latest dependencies #1268
[main] Upgrade to latest dependencies #1268
Conversation
726f702
to
5e5f7d9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
==========================================
- Coverage 82.17% 82.01% -0.17%
==========================================
Files 19 19
Lines 1790 1790
==========================================
- Hits 1471 1468 -3
- Misses 228 230 +2
- Partials 91 92 +1 ☔ View full report in Codecov by Sentry. |
needs knative/pkg#2966 |
5e5f7d9
to
b9669ea
Compare
go.mod
Outdated
go 1.18 | ||
go 1.21 | ||
|
||
toolchain go1.21.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Signed-off-by: Knative Automation <[email protected]>
b9669ea
to
804b470
Compare
Blocked on #1269 /lgtm Once the fix is in HEAD re-running the tests should make it pass and automatically merge |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, knative-automation The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
drop toolchain directive -dprotaso
/cc knative-extensions/serving-writers
/assign knative-extensions/serving-writers
Produced by: knative-extensions/knobots/actions/update-deps