Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run registry as bridge network #525

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Run registry as bridge network #525

merged 1 commit into from
Jun 18, 2024

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Jun 18, 2024

Changes

Fixes #524

  • 🧹 we run the registry by default as bridge network mode, which is supported by both: docker and podman

/kind

Fixes #

Release Note

Docs

@matzew
🧹 Run registry as bridge network
94e79c0 
Signed-off-by: Matthias Wessendorf <[email protected]>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 18, 2024

@matzew: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

Fixes #524

  • 🧹 we run the registry by default as bridge network mode, which is supported by both: docker and podman

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot requested review from psschwei and rhuss June 18, 2024 08:42
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2024
@matzew
Copy link
Contributor Author

matzew commented Jun 18, 2024

FYI: similar was done for kind example local registry before: kubernetes-sigs/kind#3407

@matzew matzew mentioned this pull request Jun 18, 2024
Open
psschwei
psschwei reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!
I would assume this should also fix issues with Podman like #408 too...

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
@knative-prow knative-prow bot merged commit 770d27b into knative-extensions:main Jun 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

@rhuss rhuss Awaiting requested review from rhuss

Assignees

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run local registry by default in bridge mode
2 participants
@matzew @psschwei