-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kind local registry setup update on Readme.md #453
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Priyansurout The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @Priyansurout! It looks like this is your first PR to knative-extensions/kn-plugin-quickstart 🎉 |
Hi @Priyansurout. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the PR! You'll need to sign the CLA before we can merge. You may also want to make a similar update in the Knative docs, as I don't think that change has made it there yet either: https://github.com/knative/docs/blob/main/docs/snippets/quickstart-install.md#run-the-knative-quickstart-plugin /ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Priyansurout thanks for the PR! Sorry for not getting to this sooner, doesn't appear that I got a github notification for it.
|
||
```bash | ||
kn quickstart kind --registry | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In light of the changes made in #468 , it would also be good to add a note about tag resolution:
Note: we automatically configure tag resolution for the local registry when this flag is passed. |
closing in favor #472 |
Changes
broom : i updated the Readme.md [For [KinD](https://kind.sigs.k8s.io/), a local registry will no longer be created by default. Users will need to pass the `--registry` flag if they wish to create a local registry:kn quickstart kind --registry
Fixes #
Release Note
when we setup kn quickstart plugin in kind by doing `kn quickstart kind ` it show " To create a local registry, use the --registry flag." in this case we have to run this command `kn quickstart kind --registry