Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kind local registry setup update on Readme.md #453

Closed

Conversation

Priyansurout
Copy link
Contributor

Changes

broom : i updated the Readme.md [For [KinD](https://kind.sigs.k8s.io/), a local registry will no longer be created by default. Users will need to pass the `--registry` flag if they wish to create a local registry:

kn quickstart kind --registry

Fixes #

Release Note

when we setup kn quickstart plugin in kind by doing `kn quickstart kind ` it show " To create a local registry, use the --registry flag." in this case we have to run this command `kn quickstart kind --registry

```

**Docs**

<!--
:book: If this change has user-visible impact, link to an issue or PR in
https://github.com/knative/docs.

See here for guidance on getting permanent links to files: https://help.github.com/en/articles/getting-permanent-links-to-files

Please use the following format for linking documentation:
- [knative/docs]: <issue or pr link>
- [Feature Track]: <link>
- [Usage]: <link>
- [Other doc]: <link>
-->
```docs

```

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 22, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Priyansurout / name: Priyansu rout (17fad8e)

@knative-prow
Copy link

knative-prow bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Priyansurout
Once this PR has been reviewed and has the lgtm label, please assign psschwei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
Copy link

knative-prow bot commented Sep 22, 2023

Welcome @Priyansurout! It looks like this is your first PR to knative-extensions/kn-plugin-quickstart 🎉

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 22, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 22, 2023

Hi @Priyansurout. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 22, 2023
@psschwei
Copy link
Contributor

Thanks for the PR! You'll need to sign the CLA before we can merge.

You may also want to make a similar update in the Knative docs, as I don't think that change has made it there yet either: https://github.com/knative/docs/blob/main/docs/snippets/quickstart-install.md#run-the-knative-quickstart-plugin

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 22, 2023
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Priyansurout thanks for the PR! Sorry for not getting to this sooner, doesn't appear that I got a github notification for it.

README.md Show resolved Hide resolved

```bash
kn quickstart kind --registry
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In light of the changes made in #468 , it would also be good to add a note about tag resolution:

Suggested change
Note: we automatically configure tag resolution for the local registry when this flag is passed.

Priyansurout added a commit to Priyansurout/kn-plugin-quickstart that referenced this pull request Nov 16, 2023
@psschwei
Copy link
Contributor

closing in favor #472

@psschwei psschwei closed this Nov 16, 2023
knative-prow bot pushed a commit that referenced this pull request Nov 16, 2023
* kind local registry setup update on Readme.md

* delete unnecessary files

* kind local registry setup update on Readme.md #453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants