#97: Added soft abort to installation if knative exists #379
Conversation
|
@ehudyonasi: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @ehudyonasi. Thanks for your PR. I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow
bot
added
needs-ok-to-test
|
@pkosiec let me know what you think of it |
|
/ok-to-test |
knative-prow
bot
added
ok-to-test
pkg/minikube/minikube.go
Outdated
| fmt.Println("deleting cluster...") | ||
| deleteCluster := exec.Command("minikube", "delete", "--profile", "--insecure-registry", clusterName) | ||
| if err := deleteCluster.Run(); err != nil { | ||
| return fmt.Errorf("delete cluster: %w", err) | ||
| } | ||
| if err := createNewCluster(); err != nil { | ||
| return fmt.Errorf("new cluster: %w", err) | ||
| } |
There was a problem hiding this comment.
let's pull this into a separate function to use here and lines 187-93
There was a problem hiding this comment.
let's pull this into a separate function to use here and lines 187-93
still need this one
There was a problem hiding this comment.
Right, will add it today.
Co-authored-by: Paul Schweigert <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehudyonasi, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Changes
/kind
Fixes #97
Release Note
Docs