Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds flags for installing knative a la carte #279

Merged
merged 1 commit into from
May 2, 2022

Conversation

psschwei
Copy link
Contributor

Signed-off-by: Paul S. Schweigert [email protected]

Changes

Adds command line flags --install-serving and install-eventing to
enable users to install only one Knative component (i.e. only serving).
Using both flags will install both components (which is also the default
behavior when no flag is passed).

Fixes #224
Release Note

Adds command line flags to let users specify which Knative component(s) they want to install. For example, `kn quickstart kind --install-serving` would create a Kind quickstart cluster with only Knative Serving installed. No flag is required, and `kn quickstart minikube` would install both Serving and Eventing, as is currently done. 

Signed-off-by: Paul S. Schweigert <[email protected]>

Adds command line flags `--install-serving` and `install-eventing` to
enable users to install only one Knative component (i.e. only serving).
Using both flags will install both components (which is also the default
behavior when no flag is passed).
@knative-prow
Copy link

knative-prow bot commented Apr 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2022
@csantanapr
Copy link
Contributor

this looks good
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2022
@knative-prow knative-prow bot merged commit 90f721b into knative-extensions:main May 2, 2022
@psschwei psschwei deleted the component-flags branch August 10, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we offer a flag to select to do serving or eventing
2 participants