-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken checksums generation #270
Conversation
Codecov Report
@@ Coverage Diff @@
## main #270 +/- ##
=======================================
Coverage 68.17% 68.17%
=======================================
Files 35 35
Lines 1128 1128
=======================================
Hits 769 769
Misses 299 299
Partials 60 60 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cardil, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@upodroid I think it looks good: $ gsutil cp -r gs://knative-nightly/kn-plugin-event/latest .
Copying gs://knative-nightly/kn-plugin-event/latest/checksums.txt...
Copying gs://knative-nightly/kn-plugin-event/latest/checksums.txt.pem...
Copying gs://knative-nightly/kn-plugin-event/latest/checksums.txt.sig...
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-darwin-amd64...
| [4 files][ 57.5 MiB/ 57.5 MiB]
==> NOTE: You are performing a sequence of gsutil operations that may
run significantly faster if you instead use gsutil -m cp ... Please
see the -m section under "gsutil help options" for further information
about when gsutil -m can be advantageous.
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-darwin-arm64...
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-linux-amd64...
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-linux-arm64...
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-linux-ppc64le...
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-linux-s390x...
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-windows-amd64...
- [10 files][398.9 MiB/398.9 MiB] 35.6 MiB/s
Operation completed over 10 objects/398.9 MiB.
$ cd latest && sha256sum --check --ignore-missing checksums.txt
kn-event-linux-amd64: OK
kn-event-linux-arm64: OK
kn-event-linux-ppc64le: OK
kn-event-linux-s390x: OK
kn-event-darwin-amd64: OK
kn-event-darwin-arm64: OK
kn-event-windows-amd64: OK |
Thanks |
…xtensions#270) * Migrate to buildah action for building multi-arch images * Ignore the 'ci/*' branches when building the multiarch image
/cc @cardil
Lets merge this, run the nightly then download the files and check before cutting a release.