Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken checksums generation #270

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Fix broken checksums generation #270

merged 1 commit into from
Feb 13, 2023

Conversation

upodroid
Copy link
Contributor

/cc @cardil

Lets merge this, run the nightly then download the files and check before cutting a release.

gsutil cp -r gs://knative-nightly/kn-plugin-event/latest .
cd latest && sha256sum --check --ignore-missing checksums.txt

@knative-prow knative-prow bot requested a review from cardil February 13, 2023 06:27
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #270 (b0c1023) into main (2226de2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   68.17%   68.17%           
=======================================
  Files          35       35           
  Lines        1128     1128           
=======================================
  Hits          769      769           
  Misses        299      299           
  Partials       60       60           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow
Copy link

knative-prow bot commented Feb 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 13, 2023
@knative-prow knative-prow bot merged commit bbb9afa into knative-extensions:main Feb 13, 2023
@cardil
Copy link
Contributor

cardil commented Feb 13, 2023

@cardil
Copy link
Contributor

cardil commented Feb 13, 2023

@upodroid I think it looks good:

$ gsutil cp -r gs://knative-nightly/kn-plugin-event/latest .                                                                                   
Copying gs://knative-nightly/kn-plugin-event/latest/checksums.txt...
Copying gs://knative-nightly/kn-plugin-event/latest/checksums.txt.pem...        
Copying gs://knative-nightly/kn-plugin-event/latest/checksums.txt.sig...        
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-darwin-amd64...    
| [4 files][ 57.5 MiB/ 57.5 MiB]                                                
==> NOTE: You are performing a sequence of gsutil operations that may
run significantly faster if you instead use gsutil -m cp ... Please
see the -m section under "gsutil help options" for further information
about when gsutil -m can be advantageous.

Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-darwin-arm64...
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-linux-amd64...     
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-linux-arm64...     
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-linux-ppc64le...   
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-linux-s390x...     
Copying gs://knative-nightly/kn-plugin-event/latest/kn-event-windows-amd64...   
- [10 files][398.9 MiB/398.9 MiB]   35.6 MiB/s                                  
Operation completed over 10 objects/398.9 MiB.

$ cd latest && sha256sum --check --ignore-missing checksums.txt
kn-event-linux-amd64: OK
kn-event-linux-arm64: OK
kn-event-linux-ppc64le: OK
kn-event-linux-s390x: OK
kn-event-darwin-amd64: OK
kn-event-darwin-arm64: OK
kn-event-windows-amd64: OK

@upodroid
Copy link
Contributor Author

Thanks

dsimansk pushed a commit to dsimansk/kn-plugin-event that referenced this pull request Jul 4, 2023
…xtensions#270)

* Migrate to buildah action for building multi-arch images

* Ignore the 'ci/*' branches when building the multiarch image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants