Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid to print runtime error if kubectl context is not set #32

Closed
chaozbj opened this issue Dec 9, 2020 · 1 comment · Fixed by #40
Closed

Avoid to print runtime error if kubectl context is not set #32

chaozbj opened this issue Dec 9, 2020 · 1 comment · Fixed by #40
Assignees
@chaozbj

Comments

@chaozbj
Copy link
Contributor

chaozbj commented Dec 9, 2020

This issue has already been addressed in the old repository, but we may lost these changes when we moved to the new repository. I would like to fix it again in our new repository. Please see the details from the original issue: knative/client-contrib#70
@chaozbj
Copy link
Contributor Author

chaozbj commented Dec 10, 2020

/assign

@chaozbj chaozbj mentioned this issue Dec 10, 2020
Closed
chaozbj added a commit to chaozbj/kn-plugin-admin that referenced this issue Dec 18, 2020
@chaozbj
knative-extensions#32 avoid to print runtime error if kubectl context…
5673ed2 
… is not set

Signed-off-by: chaozbj <[email protected]>
@chaozbj chaozbj mentioned this issue Dec 18, 2020
Merged
knative-prow-robot pushed a commit that referenced this issue Dec 20, 2020
@chaozbj
Avoid to print runtime error if kubectl context is not set (#40)
731f31e 
* #32 avoid to print runtime error if kubectl context is not set

Signed-off-by: chaozbj <[email protected]>

* fix test coverage

Signed-off-by: chaozbj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chaozbj chaozbj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid to print runtime error if kubectl context is not set chaozbj/kn-plugin-admin
1 participant
@chaozbj