Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented reconnects for jetstream channels #409

Conversation

astelmashenko
Copy link
Member

Backport of PR #408

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2023
@knative-prow knative-prow bot requested review from aliok and matzew July 7, 2023 15:40
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #409 (5d8efcf) into release-1.10 (67f77c7) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.10     #409   +/-   ##
=============================================
  Coverage         38.97%   38.97%           
=============================================
  Files                29       29           
  Lines              1919     1919           
=============================================
  Hits                748      748           
  Misses             1125     1125           
  Partials             46       46           

@astelmashenko astelmashenko marked this pull request as ready for review July 11, 2023 15:25
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2023
@knative-prow knative-prow bot requested a review from odacremolbap July 11, 2023 15:25
@astelmashenko
Copy link
Member Author

/assign @pierDipi

@astelmashenko
Copy link
Member Author

@pierDipi , please take a look at this one, it is backport to release 1.10 of #408

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astelmashenko, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@knative-prow knative-prow bot merged commit ee5f242 into knative-extensions:release-1.10 Jul 11, 2023
@astelmashenko astelmashenko deleted the feature/jetstream-reconnect-options-backported-to-1.10 branch July 12, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants