upgraded nats/jetstream libraries #1689
astelmashenkoknative-style.yaml
on: pull_request
style
/
changes
3s
style
/
...
/
Auto-format and Check
13s
style
/
...
/
Lint
1m 47s
style
/
...
/
Do Not Submit
13s
style
/
...
/
shell
0s
style
/
...
/
yaml
27s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
8 errors and 5 warnings
|
style / Golang / Lint:
pkg/channel/jetstream/controller/reconciler.go#L70
func `newReconciledNormal` is unused (unused)
|
|
style / Golang / Lint:
pkg/common/error/subscriber.go#L36
S1009: should omit nil check; len() for knative.dev/eventing-natss/pkg/common/error.SubscriberErrors is defined as zero (gosimple)
|
|
style / Golang / Lint:
pkg/channel/jetstream/controller/controller.go#L149
SA1019: pointer.BoolPtr is deprecated: Use ptr.To instead. (staticcheck)
|
|
style / Golang / Lint:
pkg/channel/jetstream/controller/controller.go#L151
SA1019: wait.PollImmediate is deprecated: This method does not return errors from context, use PollUntilContextTimeout. Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release. (staticcheck)
|
|
style / Golang / Lint:
pkg/channel/jetstream/controller/controller.go#L35
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
|
|
style / Golang / Lint:
pkg/channel/jetstream/controller/reconciler.go#L27
SA1019: "k8s.io/utils/pointer" is deprecated: Use functions in k8s.io/utils/ptr instead: ptr.To to obtain a pointer, ptr.Deref to dereference a pointer, ptr.Equal to compare dereferenced pointers. (staticcheck)
|
|
style / Golang / Lint:
pkg/channel/jetstream/dispatcher/controller.go#L59
SA1019: tracing.SetupDynamicPublishing is deprecated: Use SetupPublishingWithDynamicConfig. (staticcheck)
|
|
style / Golang / Lint
issues found
|
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-natss/eventing-natss. Supported file pattern: go.sum
|
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-natss/eventing-natss. Supported file pattern: go.sum
|
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-natss/eventing-natss. Supported file pattern: go.sum
|
|
style / suggester / yaml
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-natss/eventing-natss. Supported file pattern: go.sum
|