Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KinD test verifying the source becomes ready #515

Open
Cali0707 opened this issue May 9, 2024 · 4 comments
Open

Add KinD test verifying the source becomes ready #515

Cali0707 opened this issue May 9, 2024 · 4 comments
Labels
help wanted Extra attention is needed kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@Cali0707
Copy link
Member

Cali0707 commented May 9, 2024

Overview

We recently found that even though build and unit tests had been passing, the receive adapter panicked when it started when you actually deployed the github source. To address this, we should add a KinD test job that will:

  1. Install eventing and the github source
  2. Create a github source
  3. Verify that the source becomes ready

More info

These resources will likely be helpful while working on this:

@Cali0707
Copy link
Member Author

Cali0707 commented May 9, 2024

/help

Copy link

knative-prow bot commented May 9, 2024

@Cali0707:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the help wanted Extra attention is needed label May 9, 2024
Copy link

github-actions bot commented Aug 8, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Aug 9, 2024

/remove-lifecycle stale
/triage accepted

@knative-prow knative-prow bot added triage/accepted Issues which should be fixed (post-triage) and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

1 participant