Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.13] fix: pass application context to receive adapter #478

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #473

@knative-prow knative-prow bot requested review from aslom and yuvalif May 13, 2024 15:04
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 13, 2024
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 23.42%. Comparing base (475290d) to head (d64e8b7).

Files Patch % Lines
cmd/receive_adapter/main.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.13     #478       +/-   ##
=================================================
- Coverage         68.62%   23.42%   -45.21%     
=================================================
  Files                 6       16       +10     
  Lines               153      380      +227     
=================================================
- Hits                105       89       -16     
- Misses               40      283      +243     
  Partials              8        8               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
Copy link

knative-prow bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@Cali0707
Copy link
Member

/override codecov/patch
/override codecov/project

Copy link

knative-prow bot commented May 13, 2024

@Cali0707: Cali0707 unauthorized: /override is restricted to Repo administrators.

In response to this:

/override codecov/patch
/override codecov/project

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Cali0707
Copy link
Member

@dsimansk could you help with the overrides here?

@creydr
Copy link
Contributor

creydr commented May 14, 2024

@dsimansk could you give us some overrides here :)
/assign @dsimansk

@dsimansk
Copy link

/override codecov/project
/override codecov/patch

Copy link

knative-prow bot commented May 14, 2024

@dsimansk: Overrode contexts on behalf of dsimansk: codecov/patch, codecov/project

In response to this:

/override codecov/project
/override codecov/patch

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 1c38431 into knative-extensions:release-1.13 May 14, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants