Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop everything but ceph #1

Merged
merged 2 commits into from
Sep 17, 2020
Merged

drop everything but ceph #1

merged 2 commits into from
Sep 17, 2020

Conversation

lberk
Copy link
Member

@lberk lberk commented Sep 17, 2020

Fixes knative/community#234

Proposed Changes

  • Drop all bits but ceph related
  • Move eventing-contrib/ceph to eventing-ceph

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 17, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 17, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
mattmoor
mattmoor reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

matzew
matzew approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit bd36b78 into knative-extensions:master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@matzew matzew matzew approved these changes

@coryrc coryrc Awaiting requested review from coryrc

@devguyio devguyio Awaiting requested review from devguyio

@Harwayne Harwayne Awaiting requested review from Harwayne

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@syedriko syedriko Awaiting requested review from syedriko

@tzununbekov tzununbekov Awaiting requested review from tzununbekov

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@matzew matzew

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Repo: eventing-ceph
5 participants
@lberk @knative-prow-robot @matzew @mattmoor @googlebot