nomad provider #297
Open
nomad provider #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Could you please check the broken tests? |
|
My Go version is 1.22.3. Seems that Nomad api doesn't work with older versions |
|
Maybe, it might be possible to a build constraint. Eg. koanf/providers/nats/nats_test.go Lines 1 to 2 in e988f66 Also: https://github.com/knadh/koanf/blob/master/go.work |
|
@rhnvrm will removing |
|
I think just adding the build constraint should suffice. Removing examples from workspace will not fix the broken tests, I am guessing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Nomad provider (remade).
Options: