EPUBMaker.Contentのリファクタリング #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahashim
reviewed
Dec 21, 2020
lib/epubmaker.rb
Outdated
Comment on lines
14
to
15
| # producer.contents.push(EPUBMaker::Content.new({file: "ch01.xhtml"})) | ||
| # producer.contents.push(EPUBMaker::Content.new({file: "ch02.xhtml"})) |
There was a problem hiding this comment.
Suggested change
| # producer.contents.push(EPUBMaker::Content.new({file: "ch01.xhtml"})) | |
| # producer.contents.push(EPUBMaker::Content.new({file: "ch02.xhtml"})) | |
| # producer.contents.push(EPUBMaker::Content.new(file: "ch01.xhtml")) | |
| # producer.contents.push(EPUBMaker::Content.new(file: "ch02.xhtml")) |
こういう感じでお願いします…！
takahashim
reviewed
Dec 21, 2020
lib/epubmaker/content.rb
Outdated
Comment on lines
40
to
48
| def initialize(params) | ||
| @id = params[:id] | ||
| @file = params[:file] | ||
| @media = params[:media] | ||
| @title = params[:title] | ||
| @level = params[:level] | ||
| @notoc = params[:notoc] | ||
| @properties = params[:properties] || [] | ||
| @chaptype = params[:chaptype] |
There was a problem hiding this comment.
Suggested change
| def initialize(params) | |
| @id = params[:id] | |
| @file = params[:file] | |
| @media = params[:media] | |
| @title = params[:title] | |
| @level = params[:level] | |
| @notoc = params[:notoc] | |
| @properties = params[:properties] || [] | |
| @chaptype = params[:chaptype] | |
| def initialize(file:, id: nil, media: nil, title: nil, level: nil, notoc: nil, properties: nil, chaptype: nil) | |
| @id = id | |
| @file = file | |
| @media = media | |
| @title = title | |
| @level = level | |
| @notoc = notoc | |
| @properties = properties || [] | |
| @chaptype = chaptype |
こちらはこんな感じでしょうか。コメントの通り、fileがないとエラーになるはず。
|
@takahashim ありがとうございました、これでContentはひととおりnamed parameterにできたかと。 |
takahashim
reviewed
Dec 21, 2020
lib/review/epubmaker.rb
Outdated
| end | ||
| @producer.contents.push(Content.new(hash)) | ||
| @producer.contents.push(Content.new(params)) |
There was a problem hiding this comment.
Suggested change
| @producer.contents.push(Content.new(params)) | |
| @producer.contents.push(Content.new(**params)) |
手元で確認してないですが、hashをnamed parametersに展開するときは**をつけた方が良いです（こうしないとRuby 2.7.1とかだと警告が出るはず）。
|
あとはだいたい良さそうです！ |
|
pygmentsはあとでoffにしま… とりあえずマージします |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initializeの引数を、パラメータ列挙から名前付きに変更する。