New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set title to auto built page #1547

Merged

kmuto merged 2 commits into master from webmaker-title

Aug 17, 2020

Owner

kmuto commented Aug 17, 2020

#1545 の修正

普通のページはHTMLBuilderの働きで @title が入るのだけど、

WebMaker固有で作っているindex, titlepage, part(文字列のみしかない部)については@titleを定義していなかった。これにより、最初のindexのところでnilをエスケープしようとしてエラーになっていた。
HTMLBuilderが作る @titleはエスケープ済みだが、templates側でエスケープして二重になっていた

kmuto added 2 commits

August 17, 2020 22:59


          set title to auto built page. Closes: #1545

3a23663


          @title is already escaped.

372fff1

kmuto merged commit e77b5f0 into master

kmuto deleted the webmaker-title branch

August 17, 2020 14:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet