Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use h() instead of CGI.escapeHTML() #1536

Merged
merged 1 commit into from
Aug 16, 2020
Merged

use h() instead of CGI.escapeHTML() #1536

merged 1 commit into from
Aug 16, 2020

Conversation

takahashim
Copy link
Collaborator

  • in current Ruby, use cgi/escape first and cgi/util as fallback, because cgi/escape is fast
  • remove orignal implementation in ReVIEW::HTMLUtils.escape()

@takahashim
use h() instead of CGI.escapeHTML()
a0859a5 
* in current Ruby, use `cgi/escape` first and `cgi/util` as fallback, because `cgi/escape` is fast
* remove orignal implementation in ReVIEW::HTMLUtils.escape()
@takahashim
Copy link
Collaborator Author

ReVIEW::HTMLUtils::ESC を使って独自のエスケープを実装してた人は困るかもしれません（が、それこそ独自に頑張って欲しいということで）

@kmuto
Copy link
Owner

kmuto commented Aug 16, 2020

さすがにそれを独自はいなさそうですし、review-extは基本シランガナでよいかと…

@takahashim takahashim merged commit 80a5098 into master Aug 16, 2020
@takahashim takahashim deleted the remove-cgi-escapehtml branch August 16, 2020 05:57
@kmuto
Copy link
Owner

kmuto commented Aug 30, 2020

ESCを変更してないとしても挙動として変わったこととして、「'」がこれまでは通しだったのが、'の実体参照に変わるんですね。リリースノートに書いておいたほうがよさそうかな。
メモ: #1540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takahashim @kmuto