Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ファイル名の+による作成をFile.joinへ #1153

Merged
merged 2 commits into from
Oct 30, 2018
Merged

ファイル名の+による作成をFile.joinへ #1153

merged 2 commits into from
Oct 30, 2018

Conversation

kmuto
Copy link
Owner

@kmuto kmuto commented Oct 16, 2018

#1142 の対応

テストまわりまでやる必要はなかったかもしれないけど、ついでに。
ファイルパスであることを示すためにFile.joinは判読しやすいけど、/を完全になくそうとすると冗長になりそうなので、リテラルで分割しても意味なさそうなところはそのままにしています。

@kmuto kmuto mentioned this pull request Oct 16, 2018
13 tasks
@kmuto kmuto mentioned this pull request Oct 28, 2018
24 tasks
@kmuto
Copy link
Owner Author

kmuto commented Oct 30, 2018

挙動の変化はないので入れておきます。

@kmuto kmuto merged commit 78ad0ea into master Oct 30, 2018
@kmuto kmuto deleted the filejoin2 branch October 30, 2018 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant