i18n accepts mismatched number of arguments. (fix #667)

lib/review/i18n.rb

@@ -160,7 +160,7 @@ def t(str, args = nil)
       remove_args.reverse_each do |idx|
         args.delete_at idx
       end
-      args_matched = (frmt.count("%") == args.size)
+      args_matched = (frmt.count("%") <= args.size)
       frmt.gsub!('##', '%%')
       args_matched ? (frmt % args) : frmt
     rescue

test/test_i18n.rb

@@ -181,6 +181,23 @@ def test_custom_format_numbers
     end
   end
 
+  def test_format_with_mismatched_number_of_arguments
+    Dir.mktmpdir do |dir|
+      Dir.chdir(dir) do
+        file = File.join(dir, "locale.yml")
+
+        File.open(file, "w"){|f| f.write %Q|locale: ja\nformat_number_header: "%2$d"| }
+        I18n.setup("ja")
+        assert_equal "10", I18n.t("format_number_header", [1, 10])
+
+        File.open(file, "w"){|f| f.write %Q|locale: ja\nformat_number_header: "%2$d-%1$d"| }
+        I18n.setup("ja")
+        # ERROR: returns raw format
+        assert_equal "%2$d-%1$d", I18n.t("format_number_header", [1])
+      end
+    end
+  end
+
   def test_ja
     I18n.setup("ja")
     assert_equal "図", I18n.t("image")