Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twopanedemo #2

Closed
wants to merge 87 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
0ac95ba
Add Generated Files to .gitignore (#3442)
kmelmon Oct 17, 2019
43c6508
applying package updates ***NO_CI***
rnbot Oct 17, 2019
f31f870
Support onSubmitEditing event (#3423)
ddalp Oct 17, 2019
d07bf88
applying package updates ***NO_CI***
rnbot Oct 17, 2019
f12f3f3
Support autoCapitalize Characters (#3406)
ddalp Oct 17, 2019
04e07f7
applying package updates ***NO_CI***
rnbot Oct 17, 2019
4d9e944
Fix two crashes from NativeAnimatedExamples (#3400)
StephenLPeters Oct 17, 2019
79839a4
applying package updates ***NO_CI***
rnbot Oct 17, 2019
cff6bfe
Update to [email protected] (#3459)
rnbot Oct 17, 2019
deb1beb
applying package updates ***NO_CI***
rnbot Oct 17, 2019
50f9233
Don't hardcode the path to v141 platform toolset (#3434)
asklar Oct 18, 2019
a05aca5
Add API to control Developer Menu (#3446)
kmelmon Oct 18, 2019
0bfd804
applying package updates ***NO_CI***
rnbot Oct 18, 2019
d8826d6
Fix run-windows app installation hang (#3447)
ddalp Oct 18, 2019
db41370
applying package updates ***NO_CI***
rnbot Oct 18, 2019
715de93
Introduce ChakraObjectRef and refactor ChakraRuntime (#3445)
hansenyy Oct 21, 2019
13f134f
Adding Win10Compat matrix (#3461)
harinikmsft Oct 21, 2019
d203df0
Capture detailed logs from CI loop (#3464)
kmelmon Oct 22, 2019
a011bfe
applying package updates ***NO_CI***
rnbot Oct 22, 2019
8af7fb7
Update to [email protected] (#3479)
rnbot Oct 22, 2019
7b057a5
applying package updates ***NO_CI***
rnbot Oct 22, 2019
322b86e
CalculatedAnimation (#3482)
asklar Oct 22, 2019
e1d0f61
Bump lerna from 3.17.0 to 3.18.3 (#3500)
dependabot-preview[bot] Oct 23, 2019
c48a594
Removed MainReactNativeHost from samples and use ReactApplication pro…
vmoroz Oct 23, 2019
c3d4fec
Add more logs and attempt to fix CI Loop instability: Build and Pack …
licanhua Oct 23, 2019
de96166
Update to [email protected] (#3505)
rnbot Oct 23, 2019
5c77dc8
applying package updates ***NO_CI***
rnbot Oct 23, 2019
ce0f4a3
Change vNext format for max columns to 120 (#3497)
asklar Oct 23, 2019
f017e69
Register the 2x noop start and stop listener functions in NativeAnima…
namrog84 Oct 24, 2019
c30b71f
applying package updates ***NO_CI***
rnbot Oct 24, 2019
f7ccfa1
Update URLs on React documentation (#3502)
kant Oct 24, 2019
4cf4940
fix assert/missing else when setting alignSelf to null (#3467)
namrog84 Oct 24, 2019
4cf8609
applying package updates ***NO_CI***
rnbot Oct 24, 2019
854ace2
Update native module docs (#3472)
stmoy Oct 24, 2019
ebdd161
Update VS Code debugging docs (#3489)
savatia Oct 24, 2019
cc69571
Upgrade to ChakraCore.Debugger 0.0.0.41 (#3512)
JunielKatarn Oct 24, 2019
0752e64
Fix remaining JSI unit tests and some code clean up. (#3514)
hansenyy Oct 25, 2019
fbbf39c
Run-windows fails on x86 machines (#3520)
asklar Oct 25, 2019
4383f53
applying package updates ***NO_CI***
rnbot Oct 25, 2019
95d2f98
SkipDebugFlavor (#3525)
licanhua Oct 25, 2019
6d6ebca
Update Playground readme (#3491)
harinikmsft Oct 25, 2019
b92e904
Update to [email protected] (#3526)
rnbot Oct 25, 2019
c9d57f0
applying package updates ***NO_CI***
rnbot Oct 25, 2019
911ea3c
ChakraRuntime swap back to native implementation for getPropertyNames…
stecrain Oct 25, 2019
e7f96ba
applying package updates ***NO_CI***
rnbot Oct 25, 2019
d2f0379
Bump beachball from 1.14.1 to 1.14.2 (#3511)
dependabot-preview[bot] Oct 25, 2019
2503016
Bump @types/node from 10.14.21 to 10.17.0 (#3524)
dependabot-preview[bot] Oct 25, 2019
0d6e14f
Custom View Managers E2E (#3490)
jonthysell Oct 25, 2019
02d2236
applying package updates ***NO_CI***
rnbot Oct 25, 2019
ef1419a
Update to ChakraCore.Debugger 0.0.0.42 (#3530)
JunielKatarn Oct 26, 2019
56aa9d4
Update to [email protected] (#3533)
rnbot Oct 26, 2019
505c4a8
applying package updates ***NO_CI***
rnbot Oct 26, 2019
54d9f26
Fix remote debugger for Playground app (#3535)
asklar Oct 26, 2019
d08a118
applying package updates ***NO_CI***
rnbot Oct 26, 2019
928bf26
Merge remote-tracking branch 'upstream/master'
kmelmon Oct 27, 2019
f16414c
Update GettingStarted.md
asklar Oct 27, 2019
a817bb6
Bump @types/react-native from 0.60.5 to 0.60.22 (#3539)
dependabot-preview[bot] Oct 28, 2019
e3f7a18
Bump @microsoft/api-documenter from 7.5.0 to 7.5.4 (#3540)
dependabot-preview[bot] Oct 28, 2019
161d185
Update README.md
asklar Oct 28, 2019
e3e9297
Include JSI even when building against OSS RN (#3546)
acoates-ms Oct 28, 2019
8256927
applying package updates ***NO_CI***
rnbot Oct 28, 2019
a8cb6aa
Update the CLI to consume Microsoft.ReactNative (#3532)
jonthysell Oct 29, 2019
ae3593f
applying package updates ***NO_CI***
rnbot Oct 29, 2019
af904af
Keyboard (#3541)
ddalp Oct 29, 2019
201ed02
applying package updates ***NO_CI***
rnbot Oct 29, 2019
53ffe1b
Fix crash in RS5 due to missing facade property (#3550)
asklar Oct 29, 2019
31d09fa
applying package updates ***NO_CI***
rnbot Oct 29, 2019
97955e9
Implement AccessibilityAction (#3475)
licanhua Oct 29, 2019
64094f1
saving initial work
kmelmon Oct 30, 2019
580bd6d
Use variable templates (#3548)
JunielKatarn Oct 30, 2019
94a26be
Remove dependency on pre-built Boost DateTime. (#3559)
JunielKatarn Oct 30, 2019
1a82a2c
Enable IntegrationTestHarness (#3542)
licanhua Oct 30, 2019
d958fd0
fix build error (#3422)
enm10k Oct 30, 2019
28183c1
applying package updates ***NO_CI***
rnbot Oct 30, 2019
e10725d
Set a default 3D perspective (#3551)
asklar Oct 30, 2019
2843cdd
applying package updates ***NO_CI***
rnbot Oct 30, 2019
6ec187d
Bump @types/node from 10.17.0 to 10.17.2 (#3569)
dependabot-preview[bot] Oct 31, 2019
366d3b4
Add todo stub for FacadeType::Progress in AnimatedNode (#3544)
namrog84 Oct 31, 2019
6a1c4f2
applying package updates ***NO_CI***
rnbot Oct 31, 2019
8f1aed0
Update to [email protected] (#3570)
rnbot Oct 31, 2019
988ff12
applying package updates ***NO_CI***
rnbot Oct 31, 2019
f5f98e1
Implement ChakraRuntime::getPropertyNames() properly in native. (#3568)
hansenyy Oct 31, 2019
384358c
Call native animation callbacks only once (#3574)
asklar Nov 1, 2019
baaf66e
applying package updates ***NO_CI***
rnbot Nov 1, 2019
6e8711f
Fix some nit suggestions from PR #3568. (#3572)
hansenyy Nov 1, 2019
6946f35
yarn
kmelmon Nov 1, 2019
4b61e90
merge
kmelmon Nov 1, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
24 changes: 24 additions & 0 deletions .ado/VSComponentList.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
$dir = $env:temp
if ($env:Agent_TempDirectory -ne $null)
{
$dir = $env:Agent_TempDirectory
}

$installerPath = 'C:\Program Files (x86)\Microsoft Visual Studio\Installer\'
$installationPath = . $installerPath\vswhere.exe -latest -property installationPath
$vsconfig = "$dir\vsconfig"
Write-Host "VSConfig will be at $vsconfig"

Invoke-WebRequest -Uri 'https://download.visualstudio.microsoft.com/download/pr/c4fef23e-cc45-4836-9544-70e213134bc8/1ee5717e9a1e05015756dff77eb27d554a79a6db91f2716d836df368381af9a1/vs_Enterprise.exe' -OutFile $dir\vs_enterprise.exe
$p = Start-Process -PassThru $dir\vs_enterprise.exe -RedirectStandardError $dir\err -RedirectStandardOutput $dir\out -ArgumentList "export --installpath `"$installationPath`" --quiet --config $vsconfig"
$p.WaitForExit()
$x = [Datetime]::Now.AddSeconds(60)
while (!(Test-Path $vsconfig) -and ([datetime]::Now -lt $x))
{
Sleep 5
Write-Host "Waiting for vsconfig file..."
}

Get-Content $dir\err
Get-Content $dir\out
Get-Content $vsconfig
26 changes: 10 additions & 16 deletions .ado/publish.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
name: 0.0.$(Date:yyMM.d)$(Rev:rrr)

variables:
VmImage: vs2017-win2016
VsComponents: Microsoft.VisualStudio.Component.VC.v141.x86.x64
# VCTargetsPath: 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Microsoft\VC\v150'
- template: variables/msbuild.yml
- template: variables/vs2017.yml

trigger:
batch: true
Expand Down Expand Up @@ -59,12 +58,12 @@ jobs:
inputs:
script: node ./.ado/setVersionEnvVars.js
env:
RUNNER_TEMP: $(Build.ArtifactStagingDirectory)
RUNNER_TEMP: $(Build.StagingDirectory)

- task: PublishBuildArtifacts@1
displayName: Publish VersionEnvVars
inputs:
PathtoPublish: $(Build.ArtifactStagingDirectory)/versionEnvVars
PathtoPublish: $(Build.StagingDirectory)/versionEnvVars
ArtifactName: VersionEnvVars

- job: RnwNativeBuildDesktop
Expand Down Expand Up @@ -92,21 +91,18 @@ jobs:
displayName: Download VersionEnvVars
inputs:
artifactName: VersionEnvVars
downloadPath: $(Build.ArtifactStagingDirectory)
downloadPath: $(Build.StagingDirectory)

- task: CmdLine@2
inputs:
script: node $(Build.ArtifactStagingDirectory)/versionEnvVars/versionEnvVars.js
script: node $(Build.StagingDirectory)/versionEnvVars/versionEnvVars.js

- template: templates/build-rnw.yml
parameters:
project: vnext/ReactWindows-Desktop.sln
platformToolset: v141
vsComponents: $(VsComponents)
msbuildArguments:
/p:RNW_PKG_VERSION_STR="$(RNW_PKG_VERSION_STR)"
/p:RNW_PKG_VERSION="$(RNW_PKG_VERSION)"
# /p:VCTargetsPath="$(VCTargetsPath)"

- template: templates/publish-build-artifacts-for-nuget.yml
parameters:
Expand Down Expand Up @@ -147,18 +143,16 @@ jobs:
displayName: Download VersionEnvVars
inputs:
artifactName: VersionEnvVars
downloadPath: $(Build.ArtifactStagingDirectory)
downloadPath: $(Build.StagingDirectory)

- task: CmdLine@2
inputs:
script: node $(Build.ArtifactStagingDirectory)/versionEnvVars/versionEnvVars.js
script: node $(Build.StagingDirectory)/versionEnvVars/versionEnvVars.js

- template: templates/build-rnw.yml
parameters:
project: vnext/ReactWindows-Universal.sln
vsComponents: $(VsComponents),Microsoft.VisualStudio.Component.VC.v141.ARM
msbuildArguments:
# /p:VCTargetsPath="$(VCTargetsPath)"

- template: templates/publish-build-artifacts-for-nuget.yml
parameters:
Expand Down Expand Up @@ -189,11 +183,11 @@ jobs:
displayName: Download VersionEnvVars
inputs:
artifactName: VersionEnvVars
downloadPath: $(Build.ArtifactStagingDirectory)
downloadPath: $(Build.StagingDirectory)

- task: CmdLine@2
inputs:
script: node $(Build.ArtifactStagingDirectory)/VersionEnvVars/versionEnvVars.js
script: node $(Build.StagingDirectory)/VersionEnvVars/versionEnvVars.js

# The commit tag in the nuspec requires that we use at least nuget 4.6
- task: NuGetToolInstaller@0
Expand Down
21 changes: 16 additions & 5 deletions .ado/templates/build-rnw.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,10 @@ parameters:

# NuGet & MSBuild
project:
msbuildVersion: 16.0
msBuildArchitecture: x64
preferredToolArchitecture: x64
platformToolset: v141
targetPlatformVersion: 10.0.18362.0
msbuildVersion: $(MSBuildVersion)
msBuildArchitecture: $(MSBuildArchitecture)
preferredToolArchitecture: $(MSBuildPreferredToolArchitecture)
platformToolset: $(MSBuildPlatformToolset)
msbuildArguments: ''
yarnBuildCmd: build

Expand Down Expand Up @@ -57,6 +56,8 @@ steps:
verbosityRestore: Detailed # Options: quiet, normal, detailed

- template: install-SDK.yml
parameters:
sdkVersion: $(Win10Version)

- task: PowerShell@2
displayName: Install Visual Studio dependencies
Expand All @@ -77,7 +78,17 @@ steps:
msbuildArchitecture: ${{parameters.msBuildArchitecture}}
platform: $(BuildPlatform)
configuration: $(BuildConfiguration)
createLogFile: true
logFileVerbosity: detailed
msbuildArguments:
/p:PreferredToolArchitecture=${{parameters.preferredToolArchitecture}}
/p:PlatformToolset=${{parameters.platformToolset}}
${{parameters.msbuildArguments}}

- task: PublishBuildArtifacts@1
condition: succeededOrFailed()
timeoutInMinutes: 10
inputs:
pathtoPublish: $(Build.SourcesDirectory)/${{parameters.project}}.log
artifactName: Detailed Logs for ${{parameters.project}} $(BuildConfiguration) $(BuildPlatform)
publishLocation: 'Container'
10 changes: 9 additions & 1 deletion .ado/templates/e2e-test-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,17 @@ jobs:
- task: CmdLine@2
displayName: run-windows
inputs:
script: react-native run-windows --no-packager --arch ${{ parameters.BuildPlatform }} --release --bundle --logging --force
script: react-native run-windows --no-packager --arch ${{ parameters.BuildPlatform }} --release --bundle --logging
workingDirectory: packages/E2ETest

- task: PublishBuildArtifacts@1
condition: succeededOrFailed()
timeoutInMinutes: 10
inputs:
pathtoPublish: packages/E2ETest/msbuild.binlog
artifactName: 'ReactUWPTestApp build log'
publishLocation: 'Container'

# Wait for app to launch. A workaround to avoid WinAppDriver error: Failed to locate opened application window with appId
- task: PowerShell@2
displayName: Wait for app to launch
Expand Down
5 changes: 3 additions & 2 deletions .ado/templates/install-SDK.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
parameters:
sdkVersion: 18362
sdkVersion: ''

steps:
- task: powershell@2
inputs:
targetType: filePath
filePath: vnext\Scripts\Install-WindowsSdkISO.ps1
arguments: ${{ parameters.sdkVersion }}
displayName: 'Install Insider SDK (${{ parameters.sdkVersion }})'
displayName: 'Install Insider SDK (${{ parameters.sdkVersion }})'
condition: ne('', '${{ parameters.sdkVersion }}')
6 changes: 3 additions & 3 deletions .ado/templates/publish-build-artifacts-for-nuget.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,18 @@ steps:
displayName: Copy NuGet header files
inputs:
filePath: vnext/Scripts/Tfs/Layout-Headers.ps1
arguments: -TargetRoot $(Build.ArtifactStagingDirectory)
arguments: -TargetRoot $(Build.StagingDirectory)
condition: ${{ parameters.layoutHeaders }}

- task: CopyFiles@2
displayName: Copy NuGet artifacts
inputs:
sourceFolder: $(Build.SourcesDirectory)/vnext/target/$(BuildPlatform)/$(BuildConfiguration)
targetFolder: $(Build.ArtifactStagingDirectory)/$(BuildPlatform)/$(BuildConfiguration)
targetFolder: $(Build.StagingDirectory)/$(BuildPlatform)/$(BuildConfiguration)
contents: ${{parameters.contents}}

- task: PublishBuildArtifacts@1
displayName: "Publish Artifact: ${{parameters.artifactName}}"
inputs:
artifactName: ${{parameters.artifactName}}
pathtoPublish: $(Build.ArtifactStagingDirectory)
pathtoPublish: $(Build.StagingDirectory)
16 changes: 12 additions & 4 deletions .ado/templates/react-native-init.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ steps:
restoreSolution: $(Agent.BuildDirectory)\testcli\windows\testcli.sln

- template: install-SDK.yml
parameters:
sdkVersion: $(Win10Version)

- task: PowerShell@2
displayName: Install Visual Studio dependencies
Expand All @@ -81,16 +83,22 @@ steps:
inputs:
solution: $(Agent.BuildDirectory)\testcli\windows\testcli.sln
msbuildVersion: $(MSBuildVersion) # Optional. Options: latest, 16.0, 15.0, 14.0, 12.0, 4.0
msbuildArchitecture: x86 # Optional. Options: x86, x64
msbuildArchitecture: $(MSBuildArchitecture) # Optional. Options: x86, x64
platform: ${{ parameters.platform }} # Optional
configuration: ${{ parameters.configuration }} # Optional
restoreNugetPackages: true
createLogFile: true
logFileVerbosity: detailed
msbuildArguments:
/p:PreferredToolArchitecture=$(MSBuildPreferredToolArchitecture)
/p:PlatformToolset=$(MSBuildPlatformToolset)
# /p:VCTargetsPath="C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Microsoft\VC\v150"

clean: true # Optional
- task: PublishBuildArtifacts@1
condition: succeededOrFailed()
timeoutInMinutes: 10
inputs:
pathtoPublish: $(Agent.BuildDirectory)/testcli/windows/testcli.sln.log
artifactName: Detailed Logs for testcli.sln ${{ parameters.platform }} ${{ parameters.configuration }}
publishLocation: 'Container'

- task: CmdLine@2
displayName: Create bundle testcli
Expand Down
6 changes: 6 additions & 0 deletions .ado/variables/msbuild.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
variables:
MSBuildArchitecture: x64
MSBuildPreferredToolArchitecture: x64
MSBuildPlatformToolset: v141
TargetPlatformVersion: 10.0.18362.0
Win10Version: 18362
4 changes: 4 additions & 0 deletions .ado/variables/vs2017.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
variables:
VmImage: vs2017-win2016
MSBuildVersion: 15.0
GoogleTestAdapterPath: 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\Common7\IDE\Extensions\drknwe51.xnq'
5 changes: 5 additions & 0 deletions .ado/variables/vs2019.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
variables:
VmImage: windows-2019
VsComponents: Microsoft.VisualStudio.Component.VC.v141.x86.x64,Microsoft.VisualStudio.ComponentGroup.UWP.VC.v141
MSBuildVersion: 16.0
GoogleTestAdapterPath: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\Extensions\pemwd5jw.szc'
Loading