Add "cancel" command in order to cancel print on Prusa / Marlin based Printers #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkerler
changed the title
bkerler
force-pushed
the
Prusa_support
branch
from
f72ff99
to
33beca6
Compare
Agreed, I don't think there is a |
|
Hi @bkerler and @rockstorm101, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On printing via Printrun on Prusa and Marlin based printers, if the user stops the print on the printer, Printrun will continue to print and doesn't recognize that the print run was canceled. The Prusa / Marlin based printers are sending the "action:cancel" (see here and here) command via serial port, but Printcore seems to expect "!!". This commit adds the "action:cancel" command support.
I'm not sure if pause is the right command, but I couldn't see any stop implementation.