Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Printrun project own GCoder files #1048

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Conversation

rockstorm101
Copy link
Collaborator

Dear @sivu and @iXce , I believe you were the ones that produced these files a long long time ago, so I would like your approval for this change. Please let me know what you think.

The reason behind this is that it has been picked up that the sentence "This file is copied from GCoder" is misleading in legal terms and makes it impossible to determine either licence or copyright holders. With the change I'm proposing these files will simply fall within the project-wide licence (GPL-3+) and project copyright holders.

@sivu
Copy link
Contributor

sivu commented Apr 25, 2020

this is fine with me, gcoder was a piece of gcode analysing software by me that was never published

@rockstorm101
Copy link
Collaborator Author

Hi @iXce, I know you did a lot of work on these files, are you happy with this change too?

@rockstorm101 rockstorm101 requested a review from iXce May 13, 2020 19:10
Copy link
Collaborator

@iXce iXce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sivu had the original ownership and all my work on this is definitely part of Printrun :)

@rockstorm101 rockstorm101 merged commit 0c39c4f into master Jun 26, 2020
@rockstorm101 rockstorm101 deleted the gcoder-holders branch June 26, 2020 17:05
@ManelBcn
Copy link

ManelBcn commented Oct 2, 2022

Hi all. I am new in 3d printing
Thanks for this BIG application.
But, let me say you that in the last actualization I can't see the extruders in the frontend.
Thank you for reading this message
Best regards!
NoExtruders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants