Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial popup size for Tools -> Spool Manager could stand to be a little bigger #905

Closed
siorai opened this issue Mar 8, 2018 · 6 comments
Closed

Initial popup size for Tools -> Spool Manager could stand to be a little bigger #905

siorai opened this issue Mar 8, 2018 · 6 comments
Labels
2.x Non-breaking features and fixes suitable for inclusion in future Printrun 2.x minor releases Fix in progress Reproduced
Milestone
Release 2.0.0

Comments

@siorai
Copy link
Contributor

siorai commented Mar 8, 2018 •
edited
Loading

Branch: 2.x
Commit b33d030
Environment: Win10, version 1803, OS Build 17112.1

Prior to loading a spool:
image

After loading a spool:
image

It's worth mentioning that after a spool is loaded, and the manager is closed and reopened, the window displayed is properly sized:

image

Steps to reproduce:

install via pip3 install -r requirements.txt
python3 pronterface.py
select Tools -> Spool Manager
@siorai
Copy link
Contributor Author

siorai commented Mar 8, 2018

Side note: the icon for the Spool Manager could stand to be something other than the standard icon for win32 applications as well.

@kliment
Copy link
Owner

kliment commented Mar 8, 2018

Similar issue with the new macro dialog - buttons get cut off
selection_053

@rockstorm101
Copy link
Collaborator

I'll look into this. If anyone wants to beat me to it, please go ahead.

@kliment kliment added the 2.x Non-breaking features and fixes suitable for inclusion in future Printrun 2.x minor releases label Mar 10, 2018
rockstorm101 added a commit that referenced this issue Mar 18, 2018
@rockstorm101
p/spoolmanager: Fix various GUI problems
f265256 
 * Set icons for every window.
 * Increase initial size of displayed list of spools and automate its
   resizing. (Partial fix for #905)
 * Fix error on the edit spool window: wx.Sizer.AddSpacer no longer
   accepts tuples as arguments.
@kliment
Copy link
Owner

kliment commented Mar 19, 2018

Spool manager now looks decent for me - @siorai, can you test on your setup?

@hroncok
Copy link
Collaborator

hroncok commented Mar 19, 2018

That's my spoolmanager as I open it:

spool

@rockstorm101 rockstorm101 added this to the Release 2.0.0 milestone Mar 20, 2018
@siorai
Copy link
Contributor Author

siorai commented Mar 22, 2018 •
edited
Loading

Looks great! Verified fixed on win10.

@siorai siorai closed this as completed Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Non-breaking features and fixes suitable for inclusion in future Printrun 2.x minor releases Fix in progress Reproduced
Projects
None yet
Milestone
Release 2.0.0
Development

No branches or pull requests
4 participants
@kliment @hroncok @siorai @rockstorm101