Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trials & Possessions #1170

Merged
merged 16 commits into from
Jul 27, 2024
Merged

Conversation

Eqis-Edu
Copy link
Contributor

  • Refactor "SummonWildHuntRitual" to "SummonWildRitual" to have more types of greater spirits, the wilds
    -> Allow use "summon_number" to specifie the quantity of spawner entitys

  • Possessed Hoglin always drop something
    -> Empty pool changed to: Piglin Banner Patter or Pigstep Music Disc or Nether brick (equal chances)

  • Added "Horde" possessions variation, use te "SummonWildRitual" to get items like:
    -> All Music disks;
    -> All Armors trims;
    -> All Pottery sherd;
    -> Banner pattern (Snout, Flow, Guster);
    -> Others "rare" items, normally get via world exploration. (like Sniffer Egg)
    (Note: the Wild Armor Template Trim is not dropped, but crafted using ritual)
    (Note²: “All” considers previous possessions)

  • Enemy Hordes: Husk (desert theme), Drowned (ocean theme), Creeper (disks) and Silverfish (ruins theme)

  • Added 3 tier of Possessed Breeze, the high will drop Heavy Core.

  • Added ritual to turn Vex into Allay

@klikli-dev
Copy link
Owner

That is huge! I'll check it out later today or tomorrow!

@ffuentesm
Copy link

I would also suggest to also add the normal Hoglin drops to the Possessed Hoglin in case. So you get leather and some pork in case nothing drops.

@Eqis-Edu
Copy link
Contributor Author

I would also suggest to also add the normal Hoglin drops to the Possessed Hoglin in case. So you get leather and some pork in case nothing drops.

I thought about it, but it would effectively reduce the cost of the ritual, and that is not the intention (except for netherite scrap, when return it is to lost only time and low cost material). The goal is really a "punitive" reward percentage

@ffuentesm
Copy link

I see, still the ritual page should tell about all the possible drops, or show the other optional drops from the ritual, not just the smithing template. Have the items rotate to show the options.
image

@Eqis-Edu
Copy link
Contributor Author

I don't know if EMI or JEI can switch results (I only know about ingredients using tags), to see a visual way for all possibilities I use JER which shows the mob's loot table (not yet in 1.21). Anyway, in the Spirits Dictionary all results are described in text

@ffuentesm
Copy link

I am not sure about results like this.
But I know that at least on the crafting side, you can use Ingredient lists instead of a tag. This is what the new Demon Dream Essence uses, so instead of a 2 recipe display, it shows a single recipe with two item variants. You need to use [ ] in the output to convert it into a list.

@klikli-dev
Copy link
Owner

I am not sure about results like this. But I know that at least on the crafting side, you can use Ingredient lists instead of a tag. This is what the new Demon Dream Essence uses, so instead of a 2 recipe display, it shows a single recipe with two item variants. You need to use [ ] in the output to convert it into a list.

The outputs do not support this. I think EMI/JEI would, but the underlying recipe system does not (output = item stack).
Occultism uses a custom "recipe result" with multiple outputs for miners, but that comes with hefty drawbacks, and is required for the functionality, not the rendering.

I believe that relying on emi/jei addons for drops is better, then clicking "r" will show the entity.
Alternatively the custom text for the output item could be extended to list all possible drops, however that does not integrate with the "r" function of JEI/EMI

@klikli-dev klikli-dev merged commit 0b78449 into klikli-dev:version/1.21 Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants