This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
feat: throw semantic errors #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #107. Enables kleros/kleros-juror-front#10
Pull Request Test Coverage Report for Build 546
💛 - Coveralls |
satello
previously approved these changes
Mar 22, 2018
| } else { | ||
| throw new Error('unable to buy PNK') | ||
| } | ||
| await this._Arbitrator.buyPNK(amount, arbitratorAddress, account) |
There was a problem hiding this comment.
I like how clean these are now but we won't really get user friendly errors if we don't catch them since it will just throw either truffle contract or EVM errors (which I barely consider semantic). I am assuming you are planning on giving something more user friendly on the front end?
There was a problem hiding this comment.
nvm i see you throw something nice a layer lower
| @@ -261,6 +261,7 @@ describe('Dispute Resolution', () => { | |||
| klerosPOCAddress, | |||
| other | |||
| ) | |||
| console.info(newState) | |||
| openDisputes.push(disputeId) | ||
|
|
||
| // Advance to the next dispute | ||
| disputeId++ |
|
Not sure what happened on that second test. Looks like a VM exception slipped through the cracks somewhere |
|
@satello |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107. Enables kleros/kleros-juror-front#10