Merge pull request #18 from klees/4_4_reporting

Patch for Bug in Reportcreation.
klees · Oct 30, 2015 · a4b870a · a4b870a
2 parents 42d36e6 + 56bee3c
commit a4b870a
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/Services/ReportsRepository/classes/class.ilObjReportBaseGUI.php b/Services/ReportsRepository/classes/class.ilObjReportBaseGUI.php
@@ -21,7 +21,12 @@ protected function afterConstructor() {
 		$this->gAccess = $ilAccess;
 		$this->gTabs = $ilTabs;
 
-		$this->setFilterAction();
+		// TODO: this is crapy. The root cause of this problem is, that the
+		// filter should no need to know about it's action. The _rendering_
+		// of the filter needs to know about the action.
+		if ($this->object !== null) {
+			$this->setFilterAction();
+		}
 
 		$this->order = null;
 		$this->title = null;
@@ -68,7 +73,7 @@ final public function performCommand() {
 				return $this->renderReport();
 				break;
 			default:
-				return $this->renderReport();
+				throw new ilException("Unknown Command '$cmd'.");
 		}
 	}