Skip to content

Commit

Permalink
added TODOs for ReportStudyProgramme and SP/IndividualPlanGUI
Browse files Browse the repository at this point in the history
  • Loading branch information
klees committed Feb 22, 2017
1 parent cbe29d4 commit 7476dee
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,10 @@ public function showContent()

require_once("Modules/StudyProgramme/classes/class.ilObjectFactoryWrapper.php");
$sp = \ilObjectFactoryWrapper::getInstanceByRefId($settings->getSPNodeRefId());
// TODO: Use most recent assignment, not the first that accidentially is in the list.
$assignments = $sp->getAssignmentsOf($this->g_user->getId());
// TODO: Check if there are actually assignments and print an error message if
// none could be found.
$assignment = $assignments[0];

require_once("Modules/StudyProgramme/classes/tables/class.ilIndividualPlanGUI.php");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
*
* @author Stefan Hecken <[email protected]>
*/
// TODO: rename gev_va_* lang variables here (and on other files in this folder) to prg_* variables.
// TODO: check if all lang_vars are defined in global lang/ilias_de.lang
class ilIndividualPlanGUI
{

Expand All @@ -30,6 +32,8 @@ class ilIndividualPlanGUI
*/
protected $isPost;

// TODO: Pass required attributes (i.e. assignment id and sp_ref_id) as args here.
// TODO: declare all attributes as docstrings.
public function __construct()
{
global $ilCtrl, $tpl;
Expand Down Expand Up @@ -258,6 +262,7 @@ protected function findAssignmentId()
}
}

// TODO: Remove this. The user could unambigously be retreived from the assignment.
public function setUserId($user_id)
{
$this->user_id = $user_id;
Expand Down

0 comments on commit 7476dee

Please sign in to comment.