PHPUnit: make all dataProviders static

klees · Apr 30, 2024 · 1d1730e · 1d1730e
1 parent 7fc5638
commit 1d1730e
Show file tree

Hide file tree

Showing 134 changed files with 418 additions and 400 deletions.
diff --git a/components/ILIAS/AuthApache/tests/ilWhiteListUrlValidatorTest.php b/components/ILIAS/AuthApache/tests/ilWhiteListUrlValidatorTest.php
@@ -24,7 +24,7 @@
  */
 final class ilWhiteListUrlValidatorTest extends TestCase
 {
-    public function domainProvider(): array
+    public static function domainProvider(): array
     {
         return [
             'Empty String / Empty Whitelist' => ['', [], false],

diff --git a/components/ILIAS/Badge/tests/PresentationHeaderTest.php b/components/ILIAS/Badge/tests/PresentationHeaderTest.php
@@ -88,7 +88,7 @@ public function testShow(bool $additional = false): void
         $head->show('tile_view', ...($additional_component[0] ?? []));
     }
 
-    public function showProvider(): array
+    public static function showProvider(): array
     {
         return [
             'Without additional component' => [],

diff --git a/components/ILIAS/Badge/tests/SortingTest.php b/components/ILIAS/Badge/tests/SortingTest.php
@@ -62,7 +62,7 @@ public function testOptions(): void
         ], array_keys((new Sorting())->options()));
     }
 
-    public function sortProvider(): array
+    public static function sortProvider(): array
     {
         return [
             'Default sort is title_asc' => [[], 'title_asc', 'sort_by_title_asc', 'badge', 'getTitle', ['A', 'a'], ['f', 'G'], ['d', 'c']],

diff --git a/components/ILIAS/Badge/tests/TileTest.php b/components/ILIAS/Badge/tests/TileTest.php
@@ -190,7 +190,7 @@ public function testAs(string $method, array $expected_components): void
         array_map($this->assertInstanceOf(...), $expected_components, $components);
     }
 
-    public function provideAsVariants(): array
+    public static function provideAsVariants(): array
     {
         return [
             'Test asImage.' => ['asImage', [ModalComponent::class, ImageComponent::class]],

diff --git a/components/ILIAS/Cache/tests/CacheTest.php b/components/ILIAS/Cache/tests/CacheTest.php
@@ -171,7 +171,7 @@ public function testLock(): void
         $this->assertFalse($container->isLocked());
     }
 
-    private function getInvalidLockTimes(): array
+    private static function getInvalidLockTimes(): array
     {
         return [
             [-10],

diff --git a/components/ILIAS/Certificate/tests/ilCertificateCourseLearningProgressEvaluationTest.php b/components/ILIAS/Certificate/tests/ilCertificateCourseLearningProgressEvaluationTest.php
@@ -298,7 +298,7 @@ public function testNoSubitemDefinedForEvaluation(): void
         $this->assertSame([], $completedCourses);
     }
 
-    public function globalLearningProgressStateProvder(): array
+    public static function globalLearningProgressStateProvder(): array
     {
         return [
             'LP globally enabled' => [true, []],

diff --git a/components/ILIAS/Certificate/tests/ilXlsFoParserTest.php b/components/ILIAS/Certificate/tests/ilXlsFoParserTest.php
@@ -433,7 +433,7 @@ public function testCommasWillBeConvertedToPointInDecimalSepartor(): void
         $this->assertSame('Something Processed', $output);
     }
 
-    public function nonBreakingSpaceIsAddedDataProvider(): Generator
+    public static function nonBreakingSpaceIsAddedDataProvider(): Generator
     {
         $expected_fo_with_centered_block = <<<EOT
 <?xml version="1.0"?>

diff --git a/components/ILIAS/Chatroom/tests/class.ilChatroomServerSettingsTest.php b/components/ILIAS/Chatroom/tests/class.ilChatroomServerSettingsTest.php
@@ -28,7 +28,7 @@ class ilChatroomServerSettingsTest extends TestCase
 {
     protected ilChatroomServerSettings $settings;
 
-    public function setterAndGettersProvider(): array
+    public static function setterAndGettersProvider(): array
     {
         $assertIsString = function ($actual): void {
             $this->assertIsString($actual, 'The actual return value is not a type of "string"');

diff --git a/components/ILIAS/Chatroom/tests/class.ilChatroomUserTest.php b/components/ILIAS/Chatroom/tests/class.ilChatroomUserTest.php
@@ -178,7 +178,7 @@ public function testGetChatNameSuggestionsIfNotAnonymous(): void
         $this->assertSame('jdoe', $suggestions['login']);
     }
 
-    public function usernameDataProvider(): array
+    public static function usernameDataProvider(): array
     {
         return [
             ['username', 'username'],

diff --git a/components/ILIAS/Component/tests/Dependencies/NameTest.php b/components/ILIAS/Component/tests/Dependencies/NameTest.php
@@ -43,7 +43,7 @@ public function testImproperNames(string $name): void
         $n = new Name($name);
     }
 
-    public function properNames(): array
+    public static function properNames(): array
     {
         return [
             [\ILIAS\Component\Tests::class],

diff --git a/components/ILIAS/Component/tests/Dependencies/RendererTest.php b/components/ILIAS/Component/tests/Dependencies/RendererTest.php
@@ -55,7 +55,7 @@ public function testScenario($scenario_file, $result_file, $components)
         $this->assertEquals($expected, $result);
     }
 
-    public function scenarios()
+    public static function scenarios()
     {
         return [
             "no dependencies" => ["scenario1.php", "result1.php",

diff --git a/components/ILIAS/Component/tests/Settings/ilPluginsOverviewTableTest.php b/components/ILIAS/Component/tests/Settings/ilPluginsOverviewTableTest.php
@@ -51,7 +51,7 @@ public function testCreateObject(): void
         $this->assertInstanceOf(ilPluginsOverviewTable::class, $obj);
     }
 
-    public function getImportantFieldData(): array
+    public static function getImportantFieldData(): array
     {
         return [
             [true, true],

diff --git a/components/ILIAS/Component/tests/ilPluginInfoTest.php b/components/ILIAS/Component/tests/ilPluginInfoTest.php
@@ -232,7 +232,7 @@ public function testIsCompliantToILIAS(Data\Version $version, bool $is_compliant
         $this->assertSame($is_compliant, $plugin->isCompliantToILIAS());
     }
 
-    public function versionCompliance(): array
+    public static function versionCompliance(): array
     {
         $data_factory = new Data\Factory();
         return [
@@ -318,7 +318,7 @@ public function isVersionToOld(): bool
         $this->assertEquals($is_activation_possible, $plugin->isActivationPossible());
     }
 
-    public function isActivationPossibleTruthTable(): array
+    public static function isActivationPossibleTruthTable(): array
     {
         // is_installed, supports_current_ilias, needs_update, is_version_to_old => is_activation_possible
         return [
@@ -402,7 +402,7 @@ public function isVersionToOld(): bool
         $this->assertEquals($is_activation_possible, $plugin->isActive());
     }
 
-    public function isActiveTruthTable(): array
+    public static function isActiveTruthTable(): array
     {
         // is_installed, supports_current_ilias, needs_update, is_activated, is_version_to_old => is_active
         return [
@@ -527,7 +527,7 @@ public function isActive(): bool
         $plugin->getReasonForInactivity();
     }
 
-    public function inactivityReasonTable(): array
+    public static function inactivityReasonTable(): array
     {
         // is_installed, supports_current_ilias, needs_update, is_activated, is_version_to_old => inactivity_reason
         return [

diff --git a/components/ILIAS/Contact/BuddySystem/test/ilBuddySystemRelationCollectionTest.php b/components/ILIAS/Contact/BuddySystem/test/ilBuddySystemRelationCollectionTest.php
@@ -149,7 +149,7 @@ public function testElementsCanBeFiltered(): void
     /**
      * @return array{indexed: int[][], associative: array<int, array{A: string, B: string, C: string}>, mixed: array<int, array<int|string, int|string>>, relations: \ilBuddySystemRelation&\PHPUnit\Framework\MockObject\MockObject[][]}
      */
-    public function provideElements(): array
+    public static function provideElements(): array
     {
         $relation1 = $this->getMockBuilder(ilBuddySystemRelation::class)->disableOriginalConstructor()->getMock();
         $relation2 = $this->getMockBuilder(ilBuddySystemRelation::class)->disableOriginalConstructor()->getMock();

diff --git a/components/ILIAS/ContentPage/tests/PageReadingTimeTest.php b/components/ILIAS/ContentPage/tests/PageReadingTimeTest.php
@@ -31,7 +31,7 @@
  */
 class PageReadingTimeTest extends TestCase
 {
-    public function mixedReadingTypesProvider(): array
+    public static function mixedReadingTypesProvider(): array
     {
         return [
             'Float Type' => [4.0],

diff --git a/components/ILIAS/Context/tests/ilContextTest.php b/components/ILIAS/Context/tests/ilContextTest.php
@@ -26,7 +26,7 @@ public function testInit(string $context, string $className): void
         $this->assertEquals(ilContextExtended::getClassName(), $className);
     }
 
-    public function contextProvider(): array
+    public static function contextProvider(): array
     {
         return [
             [ilContext::CONTEXT_WEB, ilContextWeb::class],