This repository has been archived by the owner on Aug 19, 2024. It is now read-only.
Add SetHeader method to Klaytn client #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan-kwon
requested review from
jeongkyun-oh,
KimKyungup and
joowon-byun
as code owners
aidan-kwon
requested review from
hqjang-pepper,
hyochan-brown,
yoomee1313 and
ehnuje
networks/rpc/http.go
Outdated
| @@ -48,9 +49,12 @@ var nullAddr, _ = net.ResolveTCPAddr("tcp", "127.0.0.1:0") | |||
|
|
|||
| type httpConn struct { | |||
| client *http.Client | |||
| url string | |||
| req *http.Request | |||
There was a problem hiding this comment.
Suggested change
| req *http.Request |
Is this 'req' field needed?
Ethereum also removed this field by adding the SetHeader method.
And all unit tests in the rpc directory pass even without this field.
There was a problem hiding this comment.
My mistake. Thank you for leting me know!
networks/rpc/http.go
Outdated
| req *http.Request | ||
| closeOnce sync.Once | ||
| closed chan struct{} | ||
| mu sync.Mutex |
There was a problem hiding this comment.
Suggested change
| mu sync.Mutex | |
| mu sync.Mutex // protects headers |
It might be useful for later to write down the use of the mutex.
There was a problem hiding this comment.
I added the comment. Thanks!
hqjang-pepper
approved these changes
Aug 6, 2021
yoomee1313
approved these changes
Aug 9, 2021
jeongkyun-oh
approved these changes
Aug 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change adds
SetHeadermethod to Klaytn client.With this change, KAS or Infura users which need HTTP Header configuration for credentials can use Klaytn client also.
Most of this change is imported from ethereum/go-ethereum#21392
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
$ make test)