This repository has been archived by the owner on Jul 23, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR introduces modification of caver-wallet
Removed Wallet class and moved KeyringContainer to packages/caver-wallet/index.js (The code didn't change except
signWithKey
,signWithKeys
,signFeePayerWithKey
andsignFeePayerWithKeys
)Chagned signing function(
signWithKey
,signWithKeys
,signFeePayerWithKey
andsignFeePayerWithKeys
) in KeyringContainer to use signing function in Transaction (no more duplicated logic for signging)Changed caver.wallet.generate return type from
void
toArray<string>
Fixed scrypt-shim CI bug. (refer [email protected] has broken dependencies web3/web3.js#3210 and Fix npm installation error for websocket and scrypt-shim web3/web3.js#3211)
Implemented below functions in Keyring
After this PR caver-js v1.5.0-rc.1 will be released.
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Related issues
refer #249
close #317
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...