Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unnecessary $response var binding. #294

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Removes unnecessary $response var binding. #294

merged 1 commit into from
Mar 29, 2024

Conversation

kamidzi-klaviyo-integrations
Copy link
Contributor

@kamidzi-klaviyo-integrations kamidzi-klaviyo-integrations commented Mar 29, 2024 •
edited
Loading

Description

Fixes BUGPORT-1750

Manual Testing Steps

Pre-Submission Checklist:

  • You've updated the CHANGELOG following the steps here
  • Internal Only - If this is a release, please confirm the following:
    • The links in the changelog have been updated to point towards the new versions
    • The version has been incremented in the following places: module.xml and composer.json

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

@klaviyoit klaviyoit requested a review from cykolln March 29, 2024 15:41
@kamidzi-klaviyo-integrations kamidzi-klaviyo-integrations force-pushed the 202403_BUGPORT-1750-m-2-extension-4-1-2-undefined-variable-error branch 2 times, most recently from 2996c86 to 70b8796 Compare March 29, 2024 18:13
@kamidzi-klaviyo-integrations kamidzi-klaviyo-integrations force-pushed the 202403_BUGPORT-1750-m-2-extension-4-1-2-undefined-variable-error branch from 70b8796 to ca1717c Compare March 29, 2024 19:38
@kamidzi-klaviyo-integrations kamidzi-klaviyo-integrations changed the title Initializes missing $response. Removes unnecessary $response var binding. Mar 29, 2024
cykolln
cykolln approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@cykolln cykolln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kamidzi-klaviyo-integrations kamidzi-klaviyo-integrations merged commit d7621a3 into master Mar 29, 2024
3 checks passed
@kamidzi-klaviyo-integrations kamidzi-klaviyo-integrations deleted the 202403_BUGPORT-1750-m-2-extension-4-1-2-undefined-variable-error branch March 29, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cykolln cykolln cykolln approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamidzi-klaviyo-integrations @cykolln