-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix customer custom properties KlaviyoV3Api.php #289
Conversation
Hey, you've formatted the properties incorrectly, in the profile object, in properties is a child of data / attributes - see https://jsonformatter.org/fa628e for reference which was taken from the API example on Klaviyo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this, can you please update the Changelog and add this fix under Unreleased. We will include it in a release this week.
@cykolln sorry, are you talking to me? |
Added requested changes @cykolln |
Once CI is passing i'll merge this in. |
@JamesFX2 Hey! Looks like precommit is failing for this PR - locally you can run |
Hey, you've formatted the properties incorrectly, in the profile object, in properties is a child of data / attributes - see https://jsonformatter.org/fa628e for reference which was taken from the API example on Klaviyo
Description
Fixes bug with sending custom data on a profile to Klaviyo events API
Manual Testing Steps
This is an event we sync to Klaviyo that updates a customer profile. This field is no longer updating the contact. I've checked the API documentation and I have found this bug.