Add create archive step to CD workflow #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoucka
changed the title
smoucka
commented
Dec 13, 2023
| - name: Create GitHub Tag & Release | ||
| # Creates GH tag and release, adds zip archive as artifact to release. | ||
| uses: ncipollo/release-action@v1 | ||
| with: | ||
| tag: ${{ needs.determine-if-deploy.outputs.version }} | ||
| commit: ${{ github.sha }} | ||
| name: Release ${{ needs.determine-if-deploy.outputs.version }} | ||
| body: ${{ env.content }} | ||
| prerelease: true |
There was a problem hiding this comment.
Is there a reason we create the release as a pre-release?
There was a problem hiding this comment.
Synced with Claire offline on this. This needs to be a prerelease so it doesn't prematurely get picked up by packagist until it passes review by Adobe/M2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a step to the CD workflow to create a zip archive while excluding files that don't need to be released through a
.distignorefile.Manual Testing Steps
klaviyo_reclaim-4.1.0.zip
Pre-Submission Checklist:
NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.