Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get error message using object method not array method #272

Closed
wants to merge 2 commits into from

Conversation

jordanleslie
Copy link
Contributor

@jordanleslie jordanleslie commented Oct 26, 2023

Description

This PR fixes a bug causing a compile error when the integration is disabled in Klaviyo and we try to navigate to either the consent at checkout or newsletter tabs on the klaviyo module on the M2 admin page

Jira Ticket

Manual Testing Steps

  1. Switch into klaviyo account LzPPzc and disable the magento 2 integration
  2. Navigate to the klaviyo newsletter and consent at checkout pages on the M2 admin page
  3. You should be able to see the plugin configuration fields and not an error page with a stack trace

Pre-Submission Checklist:

  • You've updated the CHANGELOG following the steps here
  • Internal Only - If this is a release, please confirm the following:
    • The links in the changelog have been updated to point towards the new versions
    • The version has been incremented in the following places: module.xml and composer.json

NOTE: Please use the Changelogger cli tool to manage versioned file upgrades.

This is causing a compile error when the integration is disabled in Klaviyo and we try to navigate to either the consent at checkout or newsletter tabs on the klaviyo module on the M2 admin page
@jordanleslie jordanleslie marked this pull request as ready for review October 26, 2023 19:52
@jordanleslie jordanleslie requested a review from a team as a code owner October 26, 2023 19:52
@jordanleslie
Copy link
Contributor Author

I suspect we'll see this when the call to the list api endpoint fails but we've been unable to reproduce the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant