Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip: update CreateHeaderRaw to handle zip64 fields. #266

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

saracen
Copy link
Contributor

@saracen saracen commented Jun 7, 2020

This adds the zip64 field handling identical to fileWriter.Close.

Without this, it is far easier to create an invalid ZIP file. This provides convenience for when you only want to set the compressed data length and CRC32 fields after using zip.FileInfoHeader, rather than handle multiple fields manually.

Copy link
Owner

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klauspost
Copy link
Owner

Thanks for the contribution.

@klauspost klauspost merged commit 01fb757 into klauspost:master Jun 7, 2020
@saracen
Copy link
Contributor Author

saracen commented Jun 7, 2020

@klauspost Thank you for implementing the CreateHeaderRaw proposal 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants