refactor: use built-in min function

[Juneezee]

We can use the built-in min function since Go 1.21.

Reference: https://go.dev/ref/spec#Min_and_max

Summary by CodeRabbit

• Refactor

  • Removed min and min64 utility functions across multiple packages
  • Simplified size calculations in ZIP file writing process
  • Replaced explicit minimum value functions with direct comparisons

• Tests

  • Updated test utility functions to use inline comparisons

The changes primarily focus on code simplification and removal of redundant utility functions without impacting core functionality.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes involve removing min and min64 utility functions across multiple files in the Go standard library's compression and archive packages. These functions were used to calculate the minimum of two integers or unsigned integers. The modifications replace direct function calls with inline comparisons, simplifying the code structure while maintaining the same core functionality in the xerial, zip/writer, and zip/zip_test files.

Changes

File	Change Summary
snappy/xerial/xerial.go	Removed min(x, y int) function
zip/writer.go	Removed min64(x, y uint64) function Replaced min64 calls with direct min comparisons in writeHeader and CreateRaw functions
zip/zip_test.go	Removed min(x, y int64) function

Sequence Diagram

sequenceDiagram
    participant Code as Original Code
    participant Utility as Utility Functions
    participant NewCode as Updated Code
    
    Code->>Utility: Call min/min64 functions
    Utility-->>Code: Return minimum value
    
    Code->>NewCode: Direct inline comparison
    NewCode-->>Code: Return minimum value

Loading

The sequence diagram illustrates the transition from using separate utility functions for minimum value calculation to performing direct inline comparisons, which simplifies the code structure without changing its fundamental behavior.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ad807b and 6612f9d.

📒 Files selected for processing (3)

• snappy/xerial/xerial.go (0 hunks)
• zip/writer.go (2 hunks)
• zip/zip_test.go (0 hunks)

💤 Files with no reviewable changes (2)

• snappy/xerial/xerial.go
• zip/zip_test.go

🔇 Additional comments (2)

zip/writer.go (2)

409-410: Use of Go 1.21 built-in min is appropriate.

This update correctly replaces the custom min64 function with the built-in generic min, maintaining the same logic while benefiting from Go 1.21 improvements. No further changes are necessary here.

---

441-442: Check backward compatibility if targeting Go versions prior to 1.21.

While the built-in min function is elegant and reduces code, it requires Go ≥ 1.21. If the project supports older Go versions, consider adding build tags or a fallback. Otherwise, this is a solid, concise enhancement.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.