Add ability to view tasks by completed date. Fixes #158 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is no way of seeing when a task was completed, only when it was created. In order to facilitate this, whenever an item is checked, we set a completedDate. If the item is unchecked, we set the completedDate to null. We also add a new flavor of the timeline view which groups by completed date instead of by `_date`. This view filters out any incomplete items (or complete items which do not have the completedDate set).
Currently, there is no way of seeing when a task was completed, only when it was created. In order to facilitate this, whenever an item is checked, we set a completedDate. If the item is unchecked, we set the completedDate to null. We also add a new flavor of the timeline view which groups by completed date instead of by `_date`. This view filters out any incomplete items (or complete items which do not have the completedDate set).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue raised in #158. Currently, taskbook does not track "completed" or "checked" dates, only the date of creation. It was fairly trivial to begin tracking this date, and then to create a timeline view which was grouped on this data.