Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check on using auth for HTML source type #92

Merged
merged 2 commits into from
Dec 24, 2021
Merged

Conversation

klaasnicolaas
Copy link
Owner

From now on we check with every request that is for an inverter of an html source type whether a user name and password has been provided. In addition, an extra test for the codecov.

@klaasnicolaas klaasnicolaas added the enhancement Enhancement of the code, not introducing new features. label Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #92 (af96f4f) into master (3ff9e85) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          179       181    +2     
  Branches        34        35    +1     
=========================================
+ Hits           179       181    +2     
Impacted Files Coverage Δ
omnikinverter/omnikinverter.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ff9e85...af96f4f. Read the comment docs.

@klaasnicolaas klaasnicolaas merged commit 6dc33eb into master Dec 24, 2021
@klaasnicolaas klaasnicolaas deleted the add/auth-exception branch December 28, 2021 12:37
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants