Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML source support #38

Merged
merged 5 commits into from
Sep 26, 2021
Merged

Add HTML source support #38

merged 5 commits into from
Sep 26, 2021

Conversation

klaasnicolaas
Copy link
Owner

This PR will do:

  • ✨ Add support for Inverters with a HTML source
  • 🧪 Add extra test or update for the new code
  • 📚 Update the documentation
  • 🔨 Use variables in the regex function

@klaasnicolaas klaasnicolaas added documentation Solely about the documentation of the project. new-feature New features or request. refactor Improvement of existing code, not introducing new features. labels Sep 26, 2021
@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #38 (37f53ed) into master (8c6a10c) will increase coverage by 3.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   91.42%   94.94%   +3.51%     
==========================================
  Files           4        4              
  Lines         140      178      +38     
  Branches       21       29       +8     
==========================================
+ Hits          128      169      +41     
+ Misses          9        7       -2     
+ Partials        3        2       -1     
Impacted Files Coverage Δ
omnikinverter/exceptions.py 100.00% <100.00%> (ø)
omnikinverter/models.py 100.00% <100.00%> (ø)
omnikinverter/omnikinverter.py 86.95% <100.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c6a10c...37f53ed. Read the comment docs.

@klaasnicolaas klaasnicolaas changed the title Html support Add HTML source support Sep 26, 2021
@klaasnicolaas klaasnicolaas merged commit c80b29d into master Sep 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2021
@klaasnicolaas klaasnicolaas deleted the html-support branch December 28, 2021 12:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Solely about the documentation of the project. new-feature New features or request. refactor Improvement of existing code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant